Fixes overflow in libstd/io/cursor.rs "seek" #39874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ Thanks! |
|
📌 Commit a2d176e has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2017
Fixes overflow in libsdt/io/cursor.rs "seek" Fixes rust-lang#39631 Test which fails (with old implementation), then fix to implementation.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 17, 2017
Fixes overflow in libsdt/io/cursor.rs "seek" Fixes rust-lang#39631 Test which fails (with old implementation), then fix to implementation.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 17, 2017
Fixes overflow in libsdt/io/cursor.rs "seek" Fixes rust-lang#39631 Test which fails (with old implementation), then fix to implementation.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 17, 2017
Fixes overflow in libsdt/io/cursor.rs "seek" Fixes rust-lang#39631 Test which fails (with old implementation), then fix to implementation.
|
⌛ Testing commit a2d176e with merge 73415b7... |
|
💔 Test failed - status-travis |
|
Looking at the log, it seems the failure was at setup of test environment.
How does one re-run it?
…On Feb 18, 2017 10:50 AM, "bors" ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/202891973>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39874 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC_zrXs3zc4mfDSc_rdYKJvbdyPF10kNks5rdr7ggaJpZM4MChXk>
.
|
|
@bors: retry
* network error
…On Sat, Feb 18, 2017 at 6:53 AM, amosonn ***@***.***> wrote:
Looking at the log, it seems the failure was at setup of test environment.
How does one re-run it?
On Feb 18, 2017 10:50 AM, "bors" ***@***.***> wrote:
> 💔 Test failed - status-travis
> <https://travis-ci.org/rust-lang/rust/builds/202891973>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#39874 (comment)>,
or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AC_zrXs3zc4mfDSc_
rdYKJvbdyPF10kNks5rdr7ggaJpZM4MChXk>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#39874 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95F3sVaFgIP3ZXNblpCb4OB2XI4sNks5rdunfgaJpZM4MChXk>
.
|
bors
added a commit
that referenced
this pull request
Feb 21, 2017
Fixes overflow in libsdt/io/cursor.rs "seek" Fixes #39631 Test which fails (with old implementation), then fix to implementation.
|
☀️ Test successful - status-appveyor, status-travis |
amosonn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39631
Test which fails (with old implementation), then fix to implementation.