Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outline when details have focus #43977

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

GuillaumeGomez
Copy link
Member

r? @rust-lang/docs

(the green outline annoyed me a bit)

@frewsxcv
Copy link
Member

can you take a screenshot of the outline you're referring to?

@GuillaumeGomez
Copy link
Member Author

This one:

screenshot from 2017-08-18 18-07-54

@QuietMisdreavus
Copy link
Member

Isn't that just the "active link" outline? I don't see any change in firefox when i add this style manually.

@GuillaumeGomez
Copy link
Member Author

I only tested on chrome. Will check on firefox as well.

@GuillaumeGomez
Copy link
Member Author

Updated.

@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2017
@QuietMisdreavus
Copy link
Member

Aha, now that makes a change. I can get behind this one.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 23, 2017

📌 Commit b8f4e74 has been approved by QuietMisdreavus

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 23, 2017
…ietMisdreavus

Remove outline when details have focus

r? @rust-lang/docs

(the green outline annoyed me a bit)
bors added a commit that referenced this pull request Aug 23, 2017
Rollup of 8 pull requests

- Successful merges: #43631, #43977, #43983, #44016, #44039, #44043, #44047, #44054
- Failed merges:
@bors bors merged commit b8f4e74 into rust-lang:master Aug 23, 2017
@GuillaumeGomez GuillaumeGomez deleted the remove-outline branch August 23, 2017 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants