Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Fix a segfault on OSX with backtraces #44384

Merged
merged 1 commit into from
Sep 10, 2017

Conversation

alexcrichton
Copy link
Member

Apparently dladdr can succeed but still give you NULL pointers!

Closes #44379

Apparently `dladdr` can succeed but still give you NULL pointers!

Closes rust-lang#44379
@rust-highfive
Copy link
Collaborator

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank
Copy link
Contributor

estebank commented Sep 7, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2017

📌 Commit f633284 has been approved by estebank

@alexcrichton
Copy link
Member Author

@bors: rollup

@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 7, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 8, 2017
std: Fix a segfault on OSX with backtraces

Apparently `dladdr` can succeed but still give you NULL pointers!

Closes rust-lang#44379
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 9, 2017
std: Fix a segfault on OSX with backtraces

Apparently `dladdr` can succeed but still give you NULL pointers!

Closes rust-lang#44379
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 9, 2017
std: Fix a segfault on OSX with backtraces

Apparently `dladdr` can succeed but still give you NULL pointers!

Closes rust-lang#44379
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 10, 2017
std: Fix a segfault on OSX with backtraces

Apparently `dladdr` can succeed but still give you NULL pointers!

Closes rust-lang#44379
bors added a commit that referenced this pull request Sep 10, 2017
Rollup of 13 pull requests

- Successful merges: #44262, #44329, #44332, #44347, #44372, #44384, #44387, #44396, #44449, #44451, #44457, #44464, #44467
- Failed merges:
@bors bors merged commit f633284 into rust-lang:master Sep 10, 2017
@alexcrichton alexcrichton deleted the osx-segfault branch September 10, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants