--cap-lints allow switches off can_emit_warnings
#44627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This boolean field on the error `Handler` is toggled to silence warnings when `-A warnings` is passed. (This is actually a separate mechanism from the global lint level—whether there's some redundancy to be factored away here is an important question, but not one we concern ourselves with in this commit.) But the same rationale applies for `--cap-lints allow`. In particular, this makes the "soft" feature-gate warning introduced in 8492ad2 (which is not a lint, but just calls `struct_span_warn`) not pollute the builds of dependent crates. Thanks to @kennytm for pointing out the potential of `can_emit_warnings` for this purpose. Resolves rust-lang#44213.
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
I would like to nominate this for backporting to beta. |
arielb1
added
the
beta-nominated
|
r? @nrc (I think, you know how these work? Feel free to reassign). |
carols10cents
added
the
S-waiting-on-review
|
@bors: r+ This is a kind of significant change because it blurs the lines between lints and warnings, but I think in practical terms this is pure win. |
|
📌 Commit d02ceac has been approved by |
bors
added a commit
that referenced
this pull request
Sep 21, 2017
`--cap-lints allow` switches off `can_emit_warnings` This boolean field on the error `Handler` is toggled to silence warnings when `-A warnings` is passed. (This is actually a separate mechanism from the global lint level—whether there's some redundancy to be factored away here is an important question, but not one we concern ourselves with in this commit.) But the same rationale applies for `--cap-lints allow`. In particular, this makes the "soft" feature-gate warning introduced in 8492ad2 (which is not a lint, but just calls `struct_span_warn`) not pollute the builds of dependent crates. Thanks to @kennytm for pointing out the potential of `can_emit_warnings` for this purpose. Resolves #44213.
|
☀️ Test successful - status-appveyor, status-travis |
nikomatsakis
added
the
beta-accepted
|
Marking as beta-accepted. Small issue. cc @rust-lang/compiler |
|
Backporting now. |
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Sep 28, 2017
Beta 20170928 Backports of: - Allow unused extern crate again #44825 - macros: fix bug in collecting trait and impl items with derives. #44757 - `--cap-lints allow` switches off `can_emit_warnings` #44627 - Update the libc submodule #44116 - limit and clear cache obligations opportunistically #44269 - clear out projection subobligations after they are processed #43999
bors
added a commit
that referenced
this pull request
Oct 7, 2017
Beta 20170928 Backports of: - Allow unused extern crate again #44825 - macros: fix bug in collecting trait and impl items with derives. #44757 - `--cap-lints allow` switches off `can_emit_warnings` #44627 - Update the libc submodule #44116 - limit and clear cache obligations opportunistically #44269 - clear out projection subobligations after they are processed #43999 - fix logic error in #44269's `prune_cache_value_obligations` #45065 - REVERTS #43543: Cleanup some remains of `hr_lifetime_in_assoc_type` compatibility lint:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This boolean field on the error
Handleris toggled to silencewarnings when
-A warningsis passed. (This is actually a separatemechanism from the global lint level—whether there's some redundancy
to be factored away here is an important question, but not one we
concern ourselves with in this commit.) But the same rationale
applies for
--cap-lints allow. In particular, this makes the "soft"feature-gate warning introduced in 8492ad2 (which is not a lint, but
just calls
struct_span_warn) not pollute the builds of dependentcrates.
Thanks to @kennytm for pointing out the potential of
can_emit_warningsfor this purpose.Resolves #44213.