Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --enable-rustbuild config option from an example #45374

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Remove --enable-rustbuild config option from an example #45374

merged 2 commits into from
Oct 19, 2017

Conversation

topecongiro
Copy link
Contributor

--enable-rustbuild is no longer recognized by the configure script. Also I think we should use ./configure and ./x.py instead of configure and ../x.py.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2017
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 18, 2017

📌 Commit e11abd1 has been approved by Mark-Simulacrum

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2017
@kennytm kennytm mentioned this pull request Oct 19, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 19, 2017
@kennytm
Rollup merge of rust-lang#45374 - topecongiro:remove-enable-rustbuild…
3de1f8b 
…-config-option, r=Mark-Simulacrum

Remove --enable-rustbuild config option from an example

`--enable-rustbuild` is no longer recognized by the configure script. Also I think we should use `./configure` and `./x.py` instead of `configure` and `../x.py`.
bors added a commit that referenced this pull request Oct 19, 2017
@bors
Auto merge of #45386 - kennytm:rollup, r=kennytm
439f752 
Rollup of 8 pull requests

- Successful merges: #45343, #45349, #45352, #45374, #45375, #45376, #45377, #45382
- Failed merges:
@bors bors merged commit e11abd1 into rust-lang:master Oct 19, 2017
@topecongiro topecongiro deleted the remove-enable-rustbuild-config-option branch October 19, 2017 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topecongiro @Mark-Simulacrum @bors @kennytm