Update compiletest's dependencies #48798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
This seems fine to me though I do worry somewhat about switching to serde since the diagnostics are serialized by rustc-serialize. But if tests pass, then I'm happy. @bors r+ |
|
📌 Commit 51f4761 has been approved by |
bors
added
S-waiting-on-bors
messense
reviewed
Mar 7, 2018
src/tools/compiletest/src/json.rs
Outdated
| use std::str::FromStr; | ||
| use std::path::Path; | ||
| use runtest::ProcRes; | ||
|
|
||
| // These structs are a subset of the ones found in | ||
| // `syntax::json`. | ||
|
|
||
| #[derive(RustcEncodable, RustcDecodable)] | ||
| #[derive(Serialize, Deserialize)] |
There was a problem hiding this comment.
Does deriving Serialize really need? I did the same thing on compiletest-rs crate several days ago and found that it's not needed for that crate. Not sure about this in-tree version though.
Drop rustc-serialize, add winapi 0.3 and Serde!
alexcrichton
force-pushed
the
compiletest-update
branch
from
51f4761 to
db824b2
Compare
|
@bors: r=Mark-Simulacrum |
|
📌 Commit db824b2 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop rustc-serialize, add winapi 0.3 and Serde!