Do not test RLS/Rustfmt if build failed #50123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid a tool being simultaneously test-pass and build-fail.
|
WIP: Verifying if the toolstate is correctly reported. RLS should be "build-fail" instead of "test-pass". |
kennytm
added
the
S-waiting-on-review
|
This looks great to me, thanks! r=me when ready |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kennytm
force-pushed
the
do-not-test-rls-if-build-failed
branch
from
ec2532a to
27d9691
Compare
|
📋 Looks like this PR is still in progress, ignoring approval |
kennytm
changed the title
|
📌 Commit 27d9691 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 22, 2018
…xcrichton Do not test RLS/Rustfmt if build failed
|
☀️ Test successful - status-appveyor, status-travis |
kennytm-githubbot
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 22, 2018
Tested on commit rust-lang/rust@0cbd310. Direct link to PR: <rust-lang/rust#50123> 💔 rls on windows: test-pass → build-fail (cc @nrc). 💔 rls on linux: test-pass → build-fail (cc @nrc).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.