stabilize RangeBounds collections_range #30877 #51033
Conversation
rename RangeBounds::start() -> start_bound() rename RangeBounds::end() -> end_bound()
was already moved to ops::RangeBounds (see rust-lang#30877)
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @bluss (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
oli-obk
added
the
T-libs-api
|
r? @dtolnay |
dtolnay
added
the
relnotes
|
@bors r+ |
|
📌 Commit f7c4a33 has been approved by |
bors
added
S-waiting-on-bors
stabilize RangeBounds collections_range #30877 The FCP for #30877 closed last month, with the decision to: 1. move from `collections::range::RangeArgument` to `ops::RangeBounds`, and 2. rename `start()` and `end()` to `start_bounds()` and `end_bounds()`. Simon Sapin already moved it to `ops::RangeBounds` in #49163. I renamed the functions, and removed the old `collections::range::RangeArgument` alias. This is my first Rust PR, please let me know if I can improve anything. This passes all tests for me, except the `clippy` tool (which uses `RangeArgument::start()`). I considered deprecating `start()` and `end()` instead of removing them, but the contribution guidelines indicate we can break `clippy` temporarily. I thought it was best to remove the functions, since we're worried about name collisions with `Range::start` and `end`. Closes #30877.
|
☀️ Test successful - status-appveyor, status-travis |
|
📣 Toolstate changed by #51033! Tested on commit 07c415c. 💔 rls on windows: test-pass → build-fail (cc @nrc, @rust-lang/infra). |
Tested on commit rust-lang/rust@07c415c. Direct link to PR: <rust-lang/rust#51033> 💔 rls on windows: test-pass → build-fail (cc @nrc, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @nrc, @rust-lang/infra). 💔 rustfmt on windows: test-pass → build-fail (cc @nrc, @rust-lang/infra). 💔 rustfmt on linux: test-pass → build-fail (cc @nrc, @rust-lang/infra).
|
It would be nice to have a |
The FCP for #30877 closed last month, with the decision to:
collections::range::RangeArgumenttoops::RangeBounds, andstart()andend()tostart_bounds()andend_bounds().Simon Sapin already moved it to
ops::RangeBoundsin #49163.I renamed the functions, and removed the old
collections::range::RangeArgumentalias.This is my first Rust PR, please let me know if I can improve anything. This passes all tests for me, except the
clippytool (which usesRangeArgument::start()).I considered deprecating
start()andend()instead of removing them, but the contribution guidelines indicate we can breakclippytemporarily. I thought it was best to remove the functions, since we're worried about name collisions withRange::startandend.Closes #30877.