Fix crate-name option in rustdoc #51256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
src/librustc/middle/cstore.rs
Outdated
| @@ -276,7 +276,7 @@ pub fn validate_crate_name(sess: Option<&Session>, s: &str, sp: Option<Span>) { | |||
| } | |||
| for c in s.chars() { | |||
| if c.is_alphanumeric() { continue } | |||
| if c == '_' { continue } | |||
| if c == '_' { continue } | |||
There was a problem hiding this comment.
Why is this unrelated whitespace fix in here?
There was a problem hiding this comment.
Oups. Just went through the code trying to understand what was going on...
|
Slightly alarming that the function at fault is the same one that rustc uses. I wonder if that function should be fixed as well? To be sure, this PR still needs to land. It's weird that we're not handing the user-provided crate name to the compiler. |
|
That's the case of most rustdoc options. The rustc function isn't at fault, the option handling on rustdoc's side is. |
GuillaumeGomez
force-pushed
the
fix-rustdoc-crate-name
branch
from
89264fa to
3cbcc5a
Compare
|
Thanks! r=me pending travis. |
|
@bors: r=QuietMisdreavus |
|
📌 Commit 3cbcc5a has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 5, 2018
…me, r=QuietMisdreavus Fix crate-name option in rustdoc Fixes rust-lang#51229. r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Jun 5, 2018
Rollup of 7 pull requests Successful merges: - #50852 (Add doc comment to hiding portions of code example) - #51183 (Update rustdoc book to suggest using Termination trait instead of hidden ‘foo’ function) - #51255 (Fix confusing error message for sub_instant) - #51256 (Fix crate-name option in rustdoc) - #51308 (Check array indices in constant propagation) - #51343 (test: Ignore some problematic tests on sparc and sparc64) - #51358 (Tests that #39963 is fixed on MIR borrowck) Failed merges:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51229.
r? @QuietMisdreavus