Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed uninitialized_statics field from Memory struct in miri #51428

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Jun 8, 2018

based on #51110

r? @oli-obk

CC @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2018
@alexreg alexreg force-pushed the uninitialized-statics-simplification branch from 78469f9 to d622eb0 Compare June 8, 2018 03:06
@alexreg
Copy link
Contributor Author

alexreg commented Jun 8, 2018

@oli-obk All tests are passing locally, just waiting on Travis here. See my message on Discord re MarkStatic, but I think this is ready to review now and merge as soon as the other PR goes through.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:50:11] .i..............................................................................i...................
[00:50:16] ....................................................................................................
[00:50:22] ....................................................................................................
[00:50:29] ....................................................................................................
[00:50:34] .............i.................iiiiiiiii...................................................
[00:50:34] 
[00:50:34] travis_fold:start:test_ui_nll
travis_time:start:test_ui_nll
Check compiletest suite=ui mode=ui compare_mode=nll (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
[00:51:27] .i..............................................................................i...................
[00:51:32] ....................................................................................................
[00:51:38] ....................................................................................................
[00:51:43] ....................................................................................................
[00:51:48] .............i.................iiiiiiiii...................................................
[00:51:48] 
[00:51:48]  finished in 74.814
[00:51:48] travis_fold:end:test_ui_nll

---
[01:02:09] ......................................................................................i.............
[01:02:15] ...............................................ii.iii...............................................
[01:02:21] ...............................................................................i....................
[01:02:26] ........................i...........................................................................
[01:02:31] ............................................................F..................................i....
[01:02:42] ....................................................................................................
[01:02:48] .F..................................................................................................
[01:02:55] ....................................................................................................
[01:03:02] ....................................................................................................
---
[01:04:04] failures:
[01:04:04] 
[01:04:04] ---- [compile-fail] compile-fail/issue-14227.rs stdout ----
[01:04:04] 
[01:04:04] error: /checkout/src/test/compile-fail/issue-14227.rs:16: unexpected error: '16:20: 16:26: could not evaluate static initializer [E0080]'
[01:04:04] 
[01:04:04] error: /checkout/src/test/compile-fail/issue-14227.rs:16: unexpected error: '16:1: 16:27: could not evaluate static initializer [E0080]'
[01:04:04] 
[01:04:04] error: /checkout/src/test/compile-fail/issue-14227.rs:16: expected error not found: constant evaluation error
[01:04:04] 
[01:04:04] error: 2 unexpected errors found, 1 expected errors not found
[01:04:04] status: exit code: 101
[01:04:04] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/compile-fail/issue-14227.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-14227/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-14227/auxiliary" "-A" "unused"
[01:04:04] unexpected errors (from JSON output): [
[01:04:04]     Error {
[01:04:04]   ile-fail] compile-fail/issue-28324.rs
[01:04:04] test result: FAILED. 2410 passed; 2 failed; 15 ignored; 0 measured; 0 filtered out
[01:04:04] 
[01:04:04] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:498:22
[01:04:04] 
[01:04:04] 
[01:04:04] 
[01:04:04] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/compile-fail" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "compile-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:04:04] 
[01:04:04] 
[01:04:04] failed to run: /checkout/obj/build/bo
62124 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor

oli-obk commented Jun 8, 2018

Could you also check how much of an impact this has on the miri submodule?

Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was less fallout than I feared!

@@ -396,26 +376,23 @@ impl<'a, 'mir, 'tcx, M: Machine<'mir, 'tcx>> Memory<'a, 'mir, 'tcx, M> {
MemoryKind::Machine(m) => format!(" ({:?})", m),
}),
// uninitialized static alloc?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover comment

Some(kind @ MemoryKind::Stack) |
Some(kind @ MemoryKind::Machine(_)) => {
kind @ MemoryKind::Stack |
kind @ MemoryKind::Machine(_) => {
self.alloc_map.insert(id, alloc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two maps can now be merged into one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yep.

@alexreg
Copy link
Contributor Author

alexreg commented Jun 8, 2018

Could you also check how much of an impact this has on the miri submodule?

How do you mean, exactly?

@alexreg
Copy link
Contributor Author

alexreg commented Jun 8, 2018

What's the Travis test failure due to, do you think? Not happening on my machine.

@alexreg alexreg force-pushed the uninitialized-statics-simplification branch from d622eb0 to 8544115 Compare June 8, 2018 14:34
@oli-obk
Copy link
Contributor

oli-obk commented Jun 8, 2018

Well... I guess we first need to fix miri on nightly before it would make sense to adjust it to the changes of this PR

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:43:38] .i..............................................................................i...................
[00:43:43] ....................................................................................................
[00:43:48] ....................................................................................................
[00:43:55] ....................................................................................................
[00:43:59] .............i.................iiiiiiiii...................................................
[00:43:59] 
[00:43:59] travis_fold:start:test_ui_nll
travis_time:start:test_ui_nll
Check compiletest suite=ui mode=ui compare_mode=nll (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
[00:44:50] .i..............................................................................i...................
[00:44:55] ....................................................................................................
[00:45:00] ....................................................................................................
[00:45:05] ....................................................................................................
[00:45:10] .............i.................iiiiiiiii...................................................
[00:45:10] 
[00:45:10]  finished in 70.736
[00:45:10] travis_fold:end:test_ui_nll

---
[00:54:24] ......................................................................................i.............
[00:54:30] ...............................................ii.iii...............................................
[00:54:34] ...............................................................................i....................
[00:54:39] ........................i...........................................................................
[00:54:44] ............................................................F..................................i....
[00:54:53] ....................................................................................................
[00:54:59] .F..................................................................................................
[00:55:04] ....................................................................................................
[00:55:10] ....................................................................................................
---
[00:56:05] failures:
[00:56:05] 
[00:56:05] ---- [compile-fail] compile-fail/issue-14227.rs stdout ----
[00:56:05] 
[00:56:05] error: /checkout/src/test/compile-fail/issue-14227.rs:16: unexpected error: '16:20: 16:26: could not evaluate static initializer [E0080]'
[00:56:05] 
[00:56:05] error: /checkout/src/test/compile-fail/issue-14227.rs:16: unexpected error: '16:1: 16:27: could not evaluate static initializer [E0080]'
[00:56:05] 
[00:56:05] error: /checkout/src/test/compile-fail/issue-14227.rs:16: expected error not found: constant evaluation error
[00:56:05] 
[00:56:05] error: 2 unexpected errors found, 1 expected errors not found
[00:56:05] status: exit code: 101
[00:56:05] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/compile-fail/issue-14227.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-14227/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-14227/auxiliary" "-A" "unused"
[00:56:05] unexpected errors (from JSON output): [
[00:56:05]     Error {
[00:56:05]         line_num: 16,
[00:56:05]         kind: Some(
[00:56:05]         ),
[00:56:05]         ),
[00:56:05]         msg: "16:20: 16:26: could not evaluate static initializer [E0080]"
[00:56:05]     Error {
[00:56:05]         line_num: 16,
[00:56:05]         kind: Some(
[00:56:05]             Error
[00:56:05]             Error
[00:56:05]         ),
[00:56:05]         msg: "16:1: 16:27: could not evaluate static initializer [E0080]"
[00:56:05] ]
[00:56:05] 
[00:56:05] not found errors (from test file): [
[00:56:05]     Error {
[00:56:05]     Error {
[00:56:05]         line_num: 16,
[00:56:05]         kind: Some(
[00:56:05]             Error
[00:56:05]         ),
[00:56:05]         msg: "constant evaluation error"
[00:56:05] ]
[00:56:05] 
[00:56:05] thread '[compile-fail] compile-fail/issue-14227.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:1284:13
[00:56:05] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:56:05] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:56:05] 
[00:56:05] ---- [compile-fail] compile-fail/issue-28324.rs stdout ----
[00:56:05] 
[00:56:05] error: /checkout/src/test/compile-fail/issue-28324.rs:17: unexpected error: '17:23: 17:44: could not evaluate static initializer [E0080]'
[00:56:05] 
[00:56:05] error: /checkout/src/test/compile-fail/issue-28324.rs:17: unexpected error: '17:1: 17:45: could not evaluate static initializer [E0080]'
[00:56:05] 
[00:56:05] error: /checkout/src/test/compile-fail/issue-28324.rs:17: expected error not found: constant evaluation error
[00:56:05] 
[00:56:05] error: 2 unexpected errors found, 1 expected errors not found
[00:56:05] status: exit code: 101
[00:56:05] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/compile-fail/issue-28324.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-28324/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-28324/auxiliary" "-A" "unused"
[00:56:05] unexpected errors (from JSON output): [
[00:56:05]     Error {
[00:56:05]         line_num: 17,
[00:56:05]         kind: Some(
[00:56:05]         ),
[00:56:05]         ),
[00:56:05]         msg: "17:23: 17:44: could not evaluate static initializer [E0080]"
[00:56:05]     Error {
[00:56:05]         line_num: 17,
[00:56:05]         kind: Some(
[00:56:05]             Error
[00:56:05]             Error
[00:56:05]         ),
[00:56:05]         msg: "17:1: 17:45: could not evaluate static initializer [E0080]"
[00:56:05] ]
[00:56:05] 
[00:56:05] not found errors (from test file): [
[00:56:05]     Error {
[00:56:05]     Error {
[00:56:05]         line_num: 17,
[00:56:05]         kind: Some(
[00:56:05]             Error
[00:56:05]         ),
[00:56:05]         msg: "constant evaluation error"
[00:56:05] ]
[00:56:05] 
[00:56:05] thread '[compile-fail] compile-fail/issue-28324.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:1284:13
[00:56:05] 
[00:56:05] 
[00:56:05] 
[00:56:05] failures:
[00:56:05]     [compile-fail] compile-fail/issue-14227.rs
[00:56:05]     [compotstrap/debug/bootstrap test
[00:56:05] Build completed unsuccessfully in 0:14:44
[00:56:05] make: *** [check] Error 1
[00:56:05] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0f4c3884
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor

oli-obk commented Jun 8, 2018

Not sure. Can you provide a TRACE=rustc_mir::interpret?

@alexreg
Copy link
Contributor Author

alexreg commented Jun 8, 2018

@oli-obk The test passes locally though so...

@alexreg
Copy link
Contributor Author

alexreg commented Jun 8, 2018

Oh, the errors are to do with tried to read foreign (extern) static messages, which is from my other PR. Let's wait until that merges, and see if they still appear. I'm not quite sure on the origin, but if a fix is needed, it's trivial (it's literally just changing the expected messages).

@pietroalbini pietroalbini added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2018
@pietroalbini
Copy link
Member

Blocked on #51110.

@alexreg alexreg force-pushed the uninitialized-statics-simplification branch from 8544115 to a254347 Compare June 24, 2018 22:25
@rust-highfive

This comment has been minimized.

@alexreg
Copy link
Contributor Author

alexreg commented Jun 24, 2018

Err, looks like a transitory issue with CI.

@pietroalbini
Copy link
Member

Manually restarted the build.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:00:58] ......................................................................................i.............
[01:01:04] ...............................................ii..iii..............................................
[01:01:09] ..............................................................................i.....................
[01:01:15] .......................i............................................................................
[01:01:19] ...........................................................F..................................i.....
[01:01:30] ....................................................................................................
[01:01:36] F...................................................................................................
[01:01:42] ....................................................................................................
[01:01:49] ....................................................................................................
---
[01:02:50] failures:
[01:02:50] 
[01:02:50] ---- [compile-fail] compile-fail/issue-14227.rs stdout ----
[01:02:50] 
[01:02:50] error: /checkout/src/test/compile-fail/issue-14227.rs:16: unexpected error: '16:20: 16:26: could not evaluate static initializer [E0080]'
[01:02:50] 
[01:02:50] error: /checkout/src/test/compile-fail/issue-14227.rs:16: unexpected error: '16:1: 16:27: could not evaluate static initializer [E0080]'
[01:02:50] 
[01:02:50] error: /checkout/src/test/compile-fail/issue-14227.rs:16: expected error not found: constant evaluation error
[01:02:50] 
[01:02:50] error: 2 unexpected errors found, 1 expected errors not found
[01:02:50] status: exit code: 101
[01:02:50] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/compile-fail/issue-14227.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-14227/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-14227/auxiliary" "-A" "unused"
[01:02:50] unexpected errors (from JSON output): [
[01:02:50]     Error {
[01:02:50]         line_num: 16,
[01:02:50]         kind: Some(
[01:02:50]         ),
[01:02:50]         ),
[01:02:50]         msg: "16:20: 16:26: could not evaluate static initializer [E0080]"
[01:02:50]     Error {
[01:02:50]         line_num: 16,
[01:02:50]         kind: Some(
[01:02:50]             Error
[01:02:50]             Error
[01:02:50]         ),
[01:02:50]         msg: "16:1: 16:27: could not evaluate static initializer [E0080]"
[01:02:50] ]
[01:02:50] 
[01:02:50] not found errors (from test file): [
[01:02:50]     Error {
[01:02:50]     Error {
[01:02:50]         line_num: 16,
[01:02:50]         kind: Some(
[01:02:50]             Error
[01:02:50]         ),
[01:02:50]         msg: "constant evaluation error"
[01:02:50] ]
[01:02:50] 
[01:02:50] thread '[compile-fail] compile-fail/issue-14227.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:1284:13
[01:02:50] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:02:50] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:02:50] 
[01:02:50] ---- [compile-fail] compile-fail/issue-28324.rs stdout ----
[01:02:50] 
[01:02:50] error: /checkout/src/test/compile-fail/issue-28324.rs:17: unexpected error: '17:23: 17:44: could not evaluate static initializer [E0080]'
[01:02:50] 
[01:02:50] error: /checkout/src/test/compile-fail/issue-28324.rs:17: unexpected error: '17:1: 17:45: could not evaluate static initializer [E0080]'
[01:02:50] 
[01:02:50] error: /checkout/src/test/compile-fail/issue-28324.rs:17: expected error not found: constant evaluation error
[01:02:50] 
[01:02:50] error: 2 unexpected errors found, 1 expected errors not found
[01:02:50] status: exit code: 101
[01:02:50] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/compile-fail/issue-28324.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-28324/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/issue-28324/auxiliary" "-A" "unused"
[01:02:50] unexpected errors (from JSON output): [
[01:02:50]     Error {
[01:02:50]         line_num: 17,
[01:02:50]         kind: Some(
[01:02:50]         ),
[01:02:50]         ),
[01:02:50]         msg: "17:23: 17:44: could not evaluate static initializer [E0080]"
[01:02:50]     Error {
[01:02:50]         line_num: 17,
[01:02:50]         kind: Some(
[01:02:50]             Error
[01:02:50]             Error
[01:02:50]         ),
[01:02:50]         msg: "17:1: 17:45: could not evaluate static initializer [E0080]"
[01:02:50] ]
[01:02:50] 
[01:02:50] not found errors (from test file): [
[01:02:50]     Error {
[01:02:50]     Error {
[01:02:50]         line_num: 17,
[01:02:50]         kind: Some(
[01:02:50]             Error
[01:02:50]         ),
[01:02:50]         msg: "constant evaluation error"
[01:02:50] ]
[01:02:50] 
[01:02:50] thread '[compile-fail] compile-fail/issue-28324.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:1284:13
[01:02:50] 
---
[01:02:50] 
[01:02:50] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:498:22
[01:02:50] 
[01:02:50] 
[01:02:50] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/compile-fail" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "compile-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:02:50] 
[01:02:50] 
[01:02:50] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:02:50] Build completed unsuccessfully in 0:15:30
[01:02:50] Build completed unsuccessfully in 0:15:30
[01:02:50] Makefile:58: recipe for target 'check' failed
[01:02:50] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:033d7a78
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg
Copy link
Contributor Author

alexreg commented Jun 25, 2018

Okay, that’s the same error I’m getting in the PR blocking this. Looks like something changed in master with the rebase.

@bors
Copy link
Contributor

bors commented Jun 29, 2018

☔ The latest upstream changes (presumably #51884) made this pull request unmergeable. Please resolve the merge conflicts.

@alexreg alexreg force-pushed the uninitialized-statics-simplification branch from a254347 to 6c22f1c Compare July 2, 2018 01:37
@alexreg
Copy link
Contributor Author

alexreg commented Jul 2, 2018

@oli-obk Okay, I've rebased over master now that #51110 has merged. I think we're ready to merge this too now!

@pietroalbini I don't know if you need to remove the S-blocked label for things to proceed, but this is just a heads up that it's no longer blocked.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:14:17]    Compiling rustc_typeck v0.0.0 (file:///checkout/src/librustc_typeck)
[00:14:17] error: unknown start of token: `
[00:14:17]   --> librustc_mir/interpret/const_eval.rs:26:41
[00:14:17]    |
[00:14:17] 26 | ||||||| parent of a2543471ec... Removed `uninitialized_statics` field from `Memory` struct in miri.
[00:14:17]    |                                         ^
[00:14:17] help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
[00:14:17]    |
[00:14:17] 26 | ||||||| parent of a2543471ec... Removed 'uninitialized_statics` field from `Memory` struct in miri.
[00:14:17] 
[00:14:17] error: aborting due to previous error
[00:14:17] 
[00:14:17] error: Could not compile `rustc_mir`.
[00:14:17] error: Could not compile `rustc_mir`.
[00:14:17] 
[00:14:17] Caused by:
[00:14:17]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_mir librustc_mir/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=8fc603afb8ea9b13 -C extra-filename=-8fc603afb8ea9b13 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-d45628fe21047b42.so --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-d8b3f1986e621085.rlib --extern byteorder=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbyteorder-09e9dbd1ef48ffa5.rlib --extern either=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libeither-b51deb005c05dd3b.rlib --extern graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-6020508f01da724d.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-023d781fbd65d983.rlib --extern log_settings=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog_settings-9c861d36e123bec8.rlib --extern polonius_engine=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libpolonius_engine-2e546cbdf217aece.rlib --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-1dddb0fa9d8a512f.so --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-be9737b074a8dae0.rlib --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-25582ce13d3618ea.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-e036f8f5b9204e52.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-066098b54e835a1f.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-05774896829b5d87.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-05774896829b5d87.rlib --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-a1b02e0d020520ac.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-f36f6cb494d373be.so -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-a59a4023b81a89b2/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-ea5907e223517cf2/out` (exit code: 101)
[00:16:12] error: build failed
[00:16:12] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:16:12] expected success, got: exit code: 101
[00:16:12] expected success, got: exit code: 101
[00:16:12] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[00:16:12] travis_fold:end:stage0-rustc

[00:16:12] travis_time:end:stage0-rustc:start=1530495875314805640,finish=1530496528904588631,duration=653589782991


[00:16:12] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:16:12] Build completed unsuccessfully in 0:11:05
[00:16:12] make: *** [all] Error 1
[00:16:12] Makefile:28: recipe for target 'all' failed
travis_time:end:1d781424:start=1530496529530720068,finish=1530496529544618279,duration=13898211
travis_fold:end:after_failure.5

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the uninitialized-statics-simplification branch from 6c22f1c to d610840 Compare July 2, 2018 02:25
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:07:55]    Compiling proc_macro v0.0.0 (file:///checkout/src/libproc_macro)
[00:08:12]    Compiling syntax_ext v0.0.0 (file:///checkout/src/libsyntax_ext)
[00:14:27]    Compiling rustc_typeck v0.0.0 (file:///checkout/src/librustc_typeck)
[00:14:27]    Compiling rustc_mir v0.0.0 (file:///checkout/src/librustc_mir)
[00:14:27] error: unknown start of token: `
[00:14:27]   --> librustc_mir/interpret/eval_context.rs:17:41
[00:14:27]    |
[00:14:27] 17 | ||||||| parent of a2543471ec... Removed `uninitialized_statics` field from `Memory` struct in miri.
[00:14:27]    |                                         ^
[00:14:27] help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
[00:14:27]    |
[00:14:27] 17 | ||||||| parent of a2543471ec... Removed 'uninitialized_statics` field from `Memory` struct in miri.
[00:14:27] 
[00:14:27] error: aborting due to previous error
[00:14:27] 
[00:14:27] error: Could not compile `rustc_mir`.
[00:14:27] error: Could not compile `rustc_mir`.
[00:14:27] 
[00:14:27] Caused by:
[00:14:27]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_mir librustc_mir/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=8fc603afb8ea9b13 -C extra-filename=-8fc603afb8ea9b13 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-d45628fe21047b42.so --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-d8b3f1986e621085.rlib --extern byteorder=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbyteorder-09e9dbd1ef48ffa5.rlib --extern either=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libeither-b51deb005c05dd3b.rlib --extern graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-6020508f01da724d.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-023d781fbd65d983.rlib --extern log_settings=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog_settings-9c861d36e123bec8.rlib --extern polonius_engine=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libpolonius_engine-2e546cbdf217aece.rlib --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-1dddb0fa9d8a512f.so --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-be9737b074a8dae0.rlib --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-25582ce13d3618ea.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-e036f8f5b9204e52.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-066098b54e835a1f.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-05774896829b5d87.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-05774896829b5d87.rlib --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-a1b02e0d020520ac.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-f36f6cb494d373be.so -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-a59a4023b81a89b2/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-ea5907e223517cf2/out` (exit code: 101)
[00:16:22] error: build failed
[00:16:22] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:16:22] expected success, got: exit code: 101
[00:16:22] expected success, got: exit code: 101
[00:16:22] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[00:16:22] travis_fold:end:stage0-rustc

[00:16:22] travis_time:end:stage0-rustc:start=1530498741937549335,finish=1530499392256924808,duration=650319375473


[00:16:22] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:16:22] Build completed unsuccessfully in 0:11:03
[00:16:22] make: *** [all] Error 1
[00:16:22] Makefile:28: recipe for target 'all' failed
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:23b60fbb:start=1530499392872789029,finish=1530499392878969663,duration=6180634
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_fold:start:after_failure.4
travis_time:start:05cd119e
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:045b92c0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

use rustc::mir::interpret::FrameInfo;
use syntax::codemap::{self, Span};
use syntax::ast::Mutability;
||||||| parent of a2543471ec... Removed `uninitialized_statics` field from `Memory` struct in miri.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase fallout

use syntax::ast::Mutability;

use rustc_data_structures::fx::{FxHashSet, FxHashMap};
||||||| parent of a2543471ec... Removed `uninitialized_statics` field from `Memory` struct in miri.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more rebase fallout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this though! WTF?

@pietroalbini pietroalbini added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 2, 2018
@alexreg alexreg force-pushed the uninitialized-statics-simplification branch from d610840 to 505ac90 Compare July 2, 2018 13:06
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:07:23]    Compiling syntax_ext v0.0.0 (file:///checkout/src/libsyntax_ext)
[00:13:09]    Compiling rustc_mir v0.0.0 (file:///checkout/src/librustc_mir)
[00:13:09]    Compiling rustc_typeck v0.0.0 (file:///checkout/src/librustc_typeck)
[00:13:11] error[E0432]: unresolved import `rustc::middle::const_val`
[00:13:11]   --> librustc_mir/interpret/eval_context.rs:13:20
[00:13:11] 13 | use rustc::middle::const_val::FrameInfo;
[00:13:11]    |                    ^^^^^^^^^ Could not find `const_val` in `middle`
[00:13:11] 
[00:13:11] error[E0432]: unresolved import `rustc::middle::const_val`
---
[00:13:22] For more information about this error, try `rustc --explain E0432`.
[00:13:22] error: Could not compile `rustc_mir`.
[00:13:22] 
[00:13:22] Caused by:
[00:13:22]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_mir librustc_mir/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=8fc603afb8ea9b13 -C extra-filename=-8fc603afb8ea9b13 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-d45628fe21047b42.so --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-d8b3f1986e621085.rlib --extern byteorder=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbyteorder-09e9dbd1ef48ffa5.rlib --extern either=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libeither-b51deb005c05dd3b.rlib --extern graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-6020508f01da724d.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-023d781fbd65d983.rlib --extern log_settings=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog_settings-9c861d36e123bec8.rlib --extern polonius_engine=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libpolonius_engine-2e546cbdf217aece.rlib --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-1dddb0fa9d8a512f.so --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-be9737b074a8dae0.rlib --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-25582ce13d3618ea.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-e036f8f5b9204e52.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-066098b54e835a1f.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-05774896829b5d87.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-05774896829b5d87.rlib --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-a1b02e0d020520ac.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-f36f6cb494d373be.so -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-a59a4023b81a89b2/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-ea5907e223517cf2/out` (exit code: 101)
[00:14:55] error: build failed
[00:14:55] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:14:55] expected success, got: exit code: 101
[00:14:55] expected success, got: exit code: 101
[00:14:55] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[00:14:55] travis_fold:end:stage0-rustc

[00:14:55] travis_time:end:stage0-rustc:start=1530537235321214720,finish=1530537834235060421,duration=598913845701


[00:14:55] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:14:55] Build completed unsuccessfully in 0:10:10
[00:14:55] make: *** [all] Error 1
[00:14:55] Makefile:28: recipe for target 'all' failed
342268 ./obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu
315036 ./src/llvm
241176 ./src/llvm-emscripten
210216 ./src/llvm/test
---
157880 ./.git/modules/src
149112 ./src/llvm-emscripten/test
143020 ./obj/build/bootstrap/debug/incremental
128512 ./obj/build/bootstrap/debug/incremental/bootstrap-146vjsckowoo9
128508 ./obj/build/bootstrap/debug/incremental/bootstrap-146vjsckowoo9/s-f2j30txesn-qmioli-3nz1e0umpw6qu
97524 ./obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends
89808 ./src/llvm/test/CodeGen
80572 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu
80568 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release
---
travis_time:end:388bf764:start=1530537834955028520,finish=1530537834967080419,duration=12051899
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01e8dcae
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0bb8fd4a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the uninitialized-statics-simplification branch from 505ac90 to 16984ed Compare July 2, 2018 13:43
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:12:54] For more information about this error, try `rustc --explain E0432`.
[00:12:54] error: Could not compile `rustc_mir`.
[00:12:54] 
[00:12:54] Caused by:
[00:12:54]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_mir librustc_mir/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=8fc603afb8ea9b13 -C extra-filename=-8fc603afb8ea9b13 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-d45628fe21047b42.so --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-d8b3f1986e621085.rlib --extern byteorder=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbyteorder-09e9dbd1ef48ffa5.rlib --extern either=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libeither-b51deb005c05dd3b.rlib --extern graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-6020508f01da724d.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-023d781fbd65d983.rlib --extern log_settings=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog_settings-9c861d36e123bec8.rlib --extern polonius_engine=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libpolonius_engine-2e546cbdf217aece.rlib --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-1dddb0fa9d8a512f.so --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-be9737b074a8dae0.rlib --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-25582ce13d3618ea.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-e036f8f5b9204e52.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-066098b54e835a1f.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-05774896829b5d87.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-05774896829b5d87.rlib --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-a1b02e0d020520ac.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-f36f6cb494d373be.so -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-a59a4023b81a89b2/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-ea5907e223517cf2/out` (exit code: 101)
[00:14:22] error: build failed
[00:14:22] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:14:22] expected success, got: exit code: 101
[00:14:22] expected success, got: exit code: 101
[00:14:22] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[00:14:22] travis_fold:end:stage0-rustc

[00:14:22] travis_time:end:stage0-rustc:start=1530539421814758792,finish=1530539995872994960,duration=574058236168


[00:14:22] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:14:22] Build completed unsuccessfully in 0:09:44
[00:14:22] Makefile:28: recipe for target 'all' failed
[00:14:22] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:18c6a13e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:16b7f650:start=1530539996512980982,finish=1530539996520239196,duration=7258214
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:015ca6c2
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:27f0860d
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the uninitialized-statics-simplification branch from 16984ed to ea806e7 Compare July 2, 2018 14:19
@oli-obk
Copy link
Contributor

oli-obk commented Jul 2, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jul 2, 2018

📌 Commit 6660c25 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 2, 2018
…ification, r=oli-obk

Removed `uninitialized_statics` field from `Memory` struct in miri

**IMPORTANT: Do not merge until rust-lang#51110 is merged**

r? @oli-obk

CC @eddyb
@bors
Copy link
Contributor

bors commented Jul 3, 2018

⌛ Testing commit 6660c25 with merge 81d5c3e...

bors added a commit that referenced this pull request Jul 3, 2018
…r=oli-obk

Removed `uninitialized_statics` field from `Memory` struct in miri

based on #51110

r? @oli-obk

CC @eddyb
@bors
Copy link
Contributor

bors commented Jul 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 81d5c3e to master...

@bors bors merged commit 6660c25 into rust-lang:master Jul 3, 2018
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #51428!

Tested on commit 81d5c3e.
Direct link to PR: #51428

🎉 miri on windows: build-fail → test-pass.
🎉 miri on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 3, 2018
Tested on commit rust-lang/rust@81d5c3e.
Direct link to PR: <rust-lang/rust#51428>

🎉 miri on windows: build-fail → test-pass.
🎉 miri on linux: build-fail → test-pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants