Various changes to existing diagnostics #51463

estebank · 2018-06-09T23:19:44Z

Add code to invalid ABI error, add span label, move list to help to make message shorter:

error[E0697]: invalid ABI: found `路濫狼á́́`
  --> $DIR/unicode.rs:11:8
   |
LL | extern "路濫狼á́́" fn foo() {} //~ ERROR invalid ABI
   |        ^^^^^^^^^ invalid ABI
   |
   = help: valid ABIs: cdecl, stdcall, fastcall, vectorcall, thiscall, aapcs, win64, sysv64, ptx-kernel, msp430-interrupt, x86-interrupt, Rust, C, system, rust-intrinsic, rust-call, platform-intrinsic, unadjusted

error[E0277]: `W` does not have a constant size known at compile-time
  --> $DIR/unsized-enum2.rs:33:8
   |
LL |     VA(W),
   |        ^ `W` does not have a constant size known at compile-time
   |
   = help: the trait `std::marker::Sized` is not implemented for `W`
   = help: consider adding a `where W: std::marker::Sized` bound
   = note: no field of an enum variant may have a dynamically sized type

error[E0277]: `Foo` cannot be sent between threads safely
  --> $DIR/E0277-2.rs:26:5
   |
LL |     is_send::<Foo>();
   |     ^^^^^^^^^^^^^^ `Foo` cannot be sent between threads safely
   |
   = help: the trait `std::marker::Send` is not implemented for `Foo`

error[E0277]: can't compare `{integer}` with `std::string::String`
  --> $DIR/binops.rs:16:7
   |
LL |     5 < String::new();
   |       ^ no implementation for `{integer} < std::string::String` and `{integer} > std::string::String`
   |
   = help: the trait `std::cmp::PartialOrd<std::string::String>` is not implemented for `{integer}`

error[E0277]: can't compare `{integer}` with `std::result::Result<{integer}, _>`
  --> $DIR/binops.rs:17:7
   |
LL |     6 == Ok(1);
   |       ^^ no implementation for `{integer} == std::result::Result<{integer}, _>`
   |
   = help: the trait `std::cmp::PartialEq<std::result::Result<{integer}, _>>` is not implemented for `{integer}`

error[E0277]: a collection of type `i32` cannot be built from an iterator over elements of type `i32`
  --> $DIR/type-check-defaults.rs:16:19
   |
LL | struct WellFormed<Z = Foo<i32, i32>>(Z);
   |                   ^ a collection of type `i32` cannot be built from `std::iter::Iterator<Item=i32>`
   |
   = help: the trait `std::iter::FromIterator<i32>` is not implemented for `i32`
note: required by `Foo`
  --> $DIR/type-check-defaults.rs:15:1
   |
LL | struct Foo<T, U: FromIterator<T>>(T, U);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Add link to book for Sized errors:

error[E0277]: `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time
  --> $DIR/const-unsized.rs:13:29
   |
LL | const CONST_0: Debug+Sync = *(&0 as &(Debug+Sync));
   |                             ^^^^^^^^^^^^^^^^^^^^^^ `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time
   |
   = help: the trait `std::marker::Sized` is not implemented for `std::fmt::Debug + std::marker::Sync + 'static`
   = note: to learn more, visit <https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types--sized>
   = note: constant expressions must have a statically known size

Point to previous line for single expected token not found (if the current token is in a different line)

rust-highfive · 2018-06-09T23:19:48Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2018-06-10T09:48:53Z

r? @nikomatsakis

pietroalbini · 2018-06-18T09:23:59Z

Ping from triage @nikomatsakis! This PR needs your review.

nikomatsakis · 2018-06-18T17:29:12Z

src/test/compile-fail/extern-types-unsized.rs

@@ -30,14 +30,14 @@ fn assert_sized<T>() { }

 fn main() {
    assert_sized::<A>();
-    //~^ ERROR the trait bound `A: std::marker::Sized` is not satisfied
+    //~^ ERROR `A` does not have a constant size known at compile-time


something about this phrasing feels repetitive (if the size is known at compile-time, it must be constant?) or maybe just odd -- it's really that values of type A do not have a known size -- maybe just drop "constant"?

A does not have a size known at compile-time

I also tried to rephrase in various ways, but I wasn't happy with them:

the compiler cannot compute the size for values of type A

values of type A do not have constant size

the size for value values of type A cannot be known at compilation time

Changed wording:

error[E0277]: the size for value values of type `str` cannot be known at compilation time --> $DIR/const-unsized.rs:22:26 | LL | static STATIC_BAR: str = *"bar"; | ^^^^^^ doesn't have a size known at compile-time | = help: the trait `std::marker::Sized` is not implemented for `str` = note: to learn more, visit <https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types--sized> = note: constant expressions must have a statically known size

nikomatsakis · 2018-06-18T17:33:40Z

src/libsyntax/parse/parser.rs

+
+                let sp = if self.token == token::Token::Eof {
+                    // EOF, don't want to point at the following char, but rather the last token
+                    self.prev_span


Is there a test reflecting this change?

It seems like I didn't add one. It was a drive-by fix for a diagnostic I saw while fixing the rest to unify the output with the other, more general unexpected token error. I'll add one after fixing the wording for Sized.

Added test.

estebank · 2018-06-20T20:04:22Z

Ping. Anything left for me to do?

nikomatsakis · 2018-06-20T20:23:48Z

@bors r+

pietroalbini · 2018-06-20T20:34:48Z

@bors are you still there?

pietroalbini · 2018-06-20T22:40:05Z

@bors r=nikomatsakis

bors · 2018-06-20T22:40:05Z

📌 Commit 28cea50 has been approved by nikomatsakis

bors · 2018-06-21T07:32:23Z

⌛ Testing commit 28cea50 with merge fbdbdb9...

Various changes to existing diagnostics * [Add code to `invalid ABI` error, add span label, move list to help to make message shorter](23ae5af): ``` error[E0697]: invalid ABI: found `路濫狼á́́` --> $DIR/unicode.rs:11:8 | LL | extern "路濫狼á́́" fn foo() {} //~ ERROR invalid ABI | ^^^^^^^^^ invalid ABI | = help: valid ABIs: cdecl, stdcall, fastcall, vectorcall, thiscall, aapcs, win64, sysv64, ptx-kernel, msp430-interrupt, x86-interrupt, Rust, C, system, rust-intrinsic, rust-call, platform-intrinsic, unadjusted ``` * [Add code to incorrect `pub` restriction error](e96fdea) * [Add message to `rustc_on_unimplemented` attributes in core to have them set a custom message _and_ label](2cc7e5e): ``` error[E0277]: `W` does not have a constant size known at compile-time --> $DIR/unsized-enum2.rs:33:8 | LL | VA(W), | ^ `W` does not have a constant size known at compile-time | = help: the trait `std::marker::Sized` is not implemented for `W` = help: consider adding a `where W: std::marker::Sized` bound = note: no field of an enum variant may have a dynamically sized type ``` ``` error[E0277]: `Foo` cannot be sent between threads safely --> $DIR/E0277-2.rs:26:5 | LL | is_send::<Foo>(); | ^^^^^^^^^^^^^^ `Foo` cannot be sent between threads safely | = help: the trait `std::marker::Send` is not implemented for `Foo` ``` ``` error[E0277]: can't compare `{integer}` with `std::string::String` --> $DIR/binops.rs:16:7 | LL | 5 < String::new(); | ^ no implementation for `{integer} < std::string::String` and `{integer} > std::string::String` | = help: the trait `std::cmp::PartialOrd<std::string::String>` is not implemented for `{integer}` ``` ``` error[E0277]: can't compare `{integer}` with `std::result::Result<{integer}, _>` --> $DIR/binops.rs:17:7 | LL | 6 == Ok(1); | ^^ no implementation for `{integer} == std::result::Result<{integer}, _>` | = help: the trait `std::cmp::PartialEq<std::result::Result<{integer}, _>>` is not implemented for `{integer}` ``` ``` error[E0277]: a collection of type `i32` cannot be built from an iterator over elements of type `i32` --> $DIR/type-check-defaults.rs:16:19 | LL | struct WellFormed<Z = Foo<i32, i32>>(Z); | ^ a collection of type `i32` cannot be built from `std::iter::Iterator<Item=i32>` | = help: the trait `std::iter::FromIterator<i32>` is not implemented for `i32` note: required by `Foo` --> $DIR/type-check-defaults.rs:15:1 | LL | struct Foo<T, U: FromIterator<T>>(T, U); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` * [Add link to book for `Sized` errors](1244dc7): ``` error[E0277]: `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time --> $DIR/const-unsized.rs:13:29 | LL | const CONST_0: Debug+Sync = *(&0 as &(Debug+Sync)); | ^^^^^^^^^^^^^^^^^^^^^^ `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time | = help: the trait `std::marker::Sized` is not implemented for `std::fmt::Debug + std::marker::Sync + 'static` = note: to learn more, visit <https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types--sized> = note: constant expressions must have a statically known size ``` * [Point to previous line for single expected token not found](4816516) (if the current token is in a different line)

bors · 2018-06-21T08:55:08Z

💔 Test failed - status-appveyor

kennytm · 2018-06-21T13:51:57Z

@bors retry

---- freshness::changing_bin_features_caches_targets stdout ----
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe build`
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t543\foo\target\debug\off1.exe`
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe build --features foo`
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t543\foo\target\debug\on1.exe`
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe build`
thread 'freshness::changing_bin_features_caches_targets' panicked at '
Expected: execs
    but: exited with exit code: 101
--- stdout
--- stderr
error: failed to remove file `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t543\foo\target\debug\foo.exe`
Caused by:
  Access is denied. (os error 5)
', tools\cargo\tests\testsuite\hamcrest.rs:13:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
    freshness::changing_bin_features_caches_targets
test result: FAILED. 1306 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out

bors · 2018-06-22T03:24:45Z

⌛ Testing commit 28cea50 with merge 4b17d31...

Various changes to existing diagnostics * [Add code to `invalid ABI` error, add span label, move list to help to make message shorter](23ae5af): ``` error[E0697]: invalid ABI: found `路濫狼á́́` --> $DIR/unicode.rs:11:8 | LL | extern "路濫狼á́́" fn foo() {} //~ ERROR invalid ABI | ^^^^^^^^^ invalid ABI | = help: valid ABIs: cdecl, stdcall, fastcall, vectorcall, thiscall, aapcs, win64, sysv64, ptx-kernel, msp430-interrupt, x86-interrupt, Rust, C, system, rust-intrinsic, rust-call, platform-intrinsic, unadjusted ``` * [Add code to incorrect `pub` restriction error](e96fdea) * [Add message to `rustc_on_unimplemented` attributes in core to have them set a custom message _and_ label](2cc7e5e): ``` error[E0277]: `W` does not have a constant size known at compile-time --> $DIR/unsized-enum2.rs:33:8 | LL | VA(W), | ^ `W` does not have a constant size known at compile-time | = help: the trait `std::marker::Sized` is not implemented for `W` = help: consider adding a `where W: std::marker::Sized` bound = note: no field of an enum variant may have a dynamically sized type ``` ``` error[E0277]: `Foo` cannot be sent between threads safely --> $DIR/E0277-2.rs:26:5 | LL | is_send::<Foo>(); | ^^^^^^^^^^^^^^ `Foo` cannot be sent between threads safely | = help: the trait `std::marker::Send` is not implemented for `Foo` ``` ``` error[E0277]: can't compare `{integer}` with `std::string::String` --> $DIR/binops.rs:16:7 | LL | 5 < String::new(); | ^ no implementation for `{integer} < std::string::String` and `{integer} > std::string::String` | = help: the trait `std::cmp::PartialOrd<std::string::String>` is not implemented for `{integer}` ``` ``` error[E0277]: can't compare `{integer}` with `std::result::Result<{integer}, _>` --> $DIR/binops.rs:17:7 | LL | 6 == Ok(1); | ^^ no implementation for `{integer} == std::result::Result<{integer}, _>` | = help: the trait `std::cmp::PartialEq<std::result::Result<{integer}, _>>` is not implemented for `{integer}` ``` ``` error[E0277]: a collection of type `i32` cannot be built from an iterator over elements of type `i32` --> $DIR/type-check-defaults.rs:16:19 | LL | struct WellFormed<Z = Foo<i32, i32>>(Z); | ^ a collection of type `i32` cannot be built from `std::iter::Iterator<Item=i32>` | = help: the trait `std::iter::FromIterator<i32>` is not implemented for `i32` note: required by `Foo` --> $DIR/type-check-defaults.rs:15:1 | LL | struct Foo<T, U: FromIterator<T>>(T, U); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` * [Add link to book for `Sized` errors](1244dc7): ``` error[E0277]: `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time --> $DIR/const-unsized.rs:13:29 | LL | const CONST_0: Debug+Sync = *(&0 as &(Debug+Sync)); | ^^^^^^^^^^^^^^^^^^^^^^ `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time | = help: the trait `std::marker::Sized` is not implemented for `std::fmt::Debug + std::marker::Sync + 'static` = note: to learn more, visit <https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types--sized> = note: constant expressions must have a statically known size ``` * [Point to previous line for single expected token not found](4816516) (if the current token is in a different line)

bors · 2018-06-22T05:25:30Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 4b17d31 to master...

lqd · 2018-07-10T10:38:12Z

src/libcore/marker.rs

@@ -88,7 +91,12 @@ impl<T: ?Sized> !Send for *mut T { }
 /// [trait object]: ../../book/first-edition/trait-objects.html
 #[stable(feature = "rust1", since = "1.0.0")]
 #[lang = "sized"]
-#[rustc_on_unimplemented = "`{Self}` does not have a constant size known at compile-time"]
+#[rustc_on_unimplemented(
+    message="the size for value values of type `{Self}` cannot be known at compilation time",


is "the size for value values" a typo here ?

It is. Can you file a ticket (or even better, a quick PR)?

I've opened #52231 to fix it

rust-highfive assigned eddyb Jun 9, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2018

estebank force-pushed the error-codes branch from 1905c74 to e842055 Compare June 10, 2018 01:43

estebank changed the title ~~Add error codes to existing diagnostics~~ Various changes to existing diagnostics Jun 10, 2018

This comment has been minimized.

Sign in to view

estebank force-pushed the error-codes branch 2 times, most recently from 81886ae to 40e0c3d Compare June 10, 2018 02:52

This comment has been minimized.

Sign in to view

rust-highfive assigned nikomatsakis and unassigned eddyb Jun 10, 2018

estebank force-pushed the error-codes branch from 40e0c3d to 069d45a Compare June 10, 2018 17:37

This comment has been minimized.

Sign in to view

nikomatsakis requested changes Jun 18, 2018

View reviewed changes

pietroalbini added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2018

estebank added 7 commits June 19, 2018 11:37

Add code to invalid ABI error

09e42bc

Add code to incorrect pub restriction error

b3a1d56

Add message to rustc_on_unimplemented attributes in core

776544f

Add link to book for Sized errors

f1dee43

Point to previous line for single expected token

a93f176

Fix tidy and remove unused method

317258c

Add test for updated parser error

76a4952

estebank force-pushed the error-codes branch from e840046 to fb48e25 Compare June 19, 2018 22:54

This comment has been minimized.

Sign in to view

estebank added 2 commits June 19, 2018 17:32

Update message for !Sized types

d4bfae1

Update error code numbers

28cea50

estebank force-pushed the error-codes branch from fb48e25 to 28cea50 Compare June 20, 2018 00:33

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2018

nikomatsakis approved these changes Jun 20, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2018

bors merged commit 28cea50 into rust-lang:master Jun 22, 2018

bors mentioned this pull request Jun 22, 2018

add dyn to display of dynamic (trait) types #51104

Merged

lqd reviewed Jul 10, 2018

View reviewed changes

estebank deleted the error-codes branch November 9, 2023 05:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various changes to existing diagnostics #51463

Various changes to existing diagnostics #51463

estebank commented Jun 9, 2018 •

edited

Loading

rust-highfive commented Jun 9, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

eddyb commented Jun 10, 2018

pietroalbini commented Jun 18, 2018

This comment has been minimized.

nikomatsakis Jun 18, 2018

estebank Jun 19, 2018

nikomatsakis Jun 18, 2018

estebank Jun 19, 2018

estebank Jun 19, 2018

This comment has been minimized.

estebank commented Jun 20, 2018

nikomatsakis commented Jun 20, 2018

pietroalbini commented Jun 20, 2018

pietroalbini commented Jun 20, 2018

bors commented Jun 20, 2018

bors commented Jun 21, 2018

bors commented Jun 21, 2018

kennytm commented Jun 21, 2018

bors commented Jun 22, 2018

bors commented Jun 22, 2018

lqd Jul 10, 2018

estebank Jul 10, 2018

lqd Jul 10, 2018

Various changes to existing diagnostics #51463

Various changes to existing diagnostics #51463

Conversation

estebank commented Jun 9, 2018 • edited Loading

rust-highfive commented Jun 9, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

eddyb commented Jun 10, 2018

pietroalbini commented Jun 18, 2018

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

estebank commented Jun 20, 2018

nikomatsakis commented Jun 20, 2018

pietroalbini commented Jun 20, 2018

pietroalbini commented Jun 20, 2018

bors commented Jun 20, 2018

bors commented Jun 21, 2018

bors commented Jun 21, 2018

kennytm commented Jun 21, 2018

bors commented Jun 22, 2018

bors commented Jun 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

estebank commented Jun 9, 2018 •

edited

Loading