Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed redundant header file import in rustllvm.h #52107

Merged
merged 1 commit into from
Jul 7, 2018
Merged

removed redundant header file import in rustllvm.h #52107

merged 1 commit into from
Jul 7, 2018

Conversation

PramodBisht
Copy link
Contributor

@PramodBisht PramodBisht commented Jul 6, 2018 •
edited
Loading

fix #52105
removed redundant header file import in rustllvm.h
cc @wqweto

@varkor
Copy link
Member

varkor commented Jul 6, 2018

(If you write "fix", "close", or "resolve" instead of "address", GitHub will automatically close #52105 when this is merged. I'm not sure why "address" isn't included.)

@stokhos stokhos added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 6, 2018
@PramodBisht
Copy link
Contributor Author

fix #52105
r? @varkor

@PramodBisht PramodBisht added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2018
@kennytm
Copy link
Member

kennytm commented Jul 7, 2018

@PramodBisht The magic word only works in the PR's comment (top comment). You could edit the post.

@PramodBisht
Copy link
Contributor Author

@kennytm done!

@hanna-kruppe
Copy link
Contributor

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 7, 2018

📌 Commit 63c3fdd has been approved by rkruppe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 7, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#52107 - PramodBisht:feature/52105, r=rkruppe
f532daa 
removed redundant header file import in rustllvm.h

fix rust-lang#52105
removed redundant header file import in rustllvm.h
cc @wqweto
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 7, 2018
Merged
bors added a commit that referenced this pull request Jul 7, 2018
@bors
Auto merge of #52132 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
9fd3d78 
Rollup of 3 pull requests

Successful merges:

 - #52087 (Update musl to 1.1.19 and add patch to fix tls issue)
 - #52107 (removed redundant header file import in rustllvm.h)
 - #52131 (Ship clippy in manifests)

Failed merges:

r? @ghost
@bors bors merged commit 63c3fdd into rust-lang:master Jul 7, 2018
@PramodBisht PramodBisht deleted the feature/52105 branch July 8, 2018 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FYI, duplicate includes in rustllvm.h
6 participants
@PramodBisht @varkor @kennytm @hanna-kruppe @bors @stokhos