Add test for unexpected region for local data ReStatic #52809
Conversation
rust-highfive
added
the
S-waiting-on-review
|
|
||
| // compile-pass | ||
|
|
||
| #![feature(nll)] |
There was a problem hiding this comment.
Does this test need to utilize #![feature(nll)]? (In other words, is there something in the test itself that requires NLL for it to compile sucessfully?)
Or can we leave that off, and let the compare-mode=nll handle testing that case (and thus get a test for this in both AST-borrowck and NLL modes)
There was a problem hiding this comment.
This test does not compile without #![feature(nll)]. I'm not sure if it is possible to allow a UI test to compile successfully in one compare mode but fail in another.
There was a problem hiding this comment.
You can use #[rustc_error] to support that. There are examples of it elsewhere in the ui/ test suite.
There was a problem hiding this comment.
but having said that, there's no reason to worry about it in this case. If the test does not compile w/o #[feature(nll)], that is fine.
pnkfelix
added
S-waiting-on-author
|
@bors r+ rollup |
|
📌 Commit 8e88d64 has been approved by |
bors
added
S-waiting-on-bors
Add test for unexpected region for local data ReStatic Fixes rust-lang#49579. r? @pnkfelix @nikomatsakis
Rollup of 15 pull requests Successful merges: - #52793 (Add test for NLL: unexpected "free region `` does not outlive" error ) - #52799 (Use BitVector for global sets of AttrId) - #52809 (Add test for unexpected region for local data ReStatic) - #52834 ([NLL] Allow conflicting borrows of promoted length zero arrays) - #52835 (Fix Alias intra doc ICE) - #52854 (fix memrchr in miri) - #52899 (tests/ui: Add missing mips{64} ignores) - #52908 (Use SetLenOnDrop in Vec::truncate()) - #52915 (Don't count MIR locals as borrowed after StorageDead when finding locals live across a yield terminator) - #52926 (rustc: Trim down the `rust_2018_idioms` lint group) - #52930 (rustc_resolve: record single-segment extern crate import resolutions.) - #52939 (Make io::Read::read_to_end consider io::Take::limit) - #52942 (Another SmallVec.extend optimization) - #52947 (1.27 actually added the `armv5te-unknown-linux-musleabi` target) - #52954 (async can begin expressions) Failed merges: r? @ghost
Fixes #49579.
r? @pnkfelix @nikomatsakis