Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustc: adjust logic for cfg attribute and add not predicate. #5410

Merged
merged 6 commits into from
Mar 20, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/compiletest/runtest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -208,18 +208,19 @@ actual:\n\
testfile: &Path, src: ~str) -> ProcRes {
compose_and_run_compiler(
config, props, testfile,
make_typecheck_args(config, testfile),
make_typecheck_args(config, props, testfile),
Some(src))
}

fn make_typecheck_args(config: config, testfile: &Path) -> ProcArgs {
fn make_typecheck_args(config: config, props: TestProps, testfile: &Path) -> ProcArgs {
let prog = config.rustc_path;
let mut args = ~[~"-",
~"--no-trans", ~"--lib",
~"-L", config.build_base.to_str(),
~"-L",
aux_output_dir_name(config, testfile).to_str()];
args += split_maybe_args(config.rustcflags);
args += split_maybe_args(props.compile_flags);
return ProcArgs {prog: prog.to_str(), args: args};
}
}
Expand Down
25 changes: 13 additions & 12 deletions src/librustc/front/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -185,18 +185,19 @@ pub fn metas_in_cfg(cfg: ast::crate_cfg,
// Pull the inner meta_items from the #[cfg(meta_item, ...)] attributes,
// so we can match against them. This is the list of configurations for
// which the item is valid
let cfg_metas =
vec::concat(
vec::filter_map(cfg_metas, |i| attr::get_meta_item_list(i)));

let has_cfg_metas = vec::len(cfg_metas) > 0u;
if !has_cfg_metas { return true; }

for cfg_metas.each |cfg_mi| {
if attr::contains(cfg, *cfg_mi) { return true; }
}

return false;
let cfg_metas = vec::filter_map(cfg_metas, |i| attr::get_meta_item_list(i));

if cfg_metas.all(|c| c.is_empty()) { return true; }

cfg_metas.any(|cfg_meta| {
cfg_meta.all(|cfg_mi| {
match cfg_mi.node {
ast::meta_list(s, ref it) if *s == ~"not"
=> it.all(|mi| !attr::contains(cfg, *mi)),
_ => attr::contains(cfg, *cfg_mi)
}
})
})
}


Expand Down
18 changes: 18 additions & 0 deletions src/test/compile-fail/test-cfg.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// compile-flags: --cfg foo

#[cfg(foo, bar)] // foo AND bar
fn foo() {}

fn main() {
foo(); //~ ERROR unresolved name: `foo`.
}
31 changes: 31 additions & 0 deletions src/test/run-pass/cfgs-on-items.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast
// compile-flags: --cfg fooA --cfg fooB

// fooA AND !bar
#[cfg(fooA, not(bar))]
fn foo1() -> int { 1 }

// !fooA AND !bar
#[cfg(not(fooA, bar))]
fn foo2() -> int { 2 }

// fooC OR (fooB AND !bar)
#[cfg(fooC)]
#[cfg(fooB, not(bar))]
fn foo2() -> int { 3 }


fn main() {
fail_unless!(1 == foo1());
fail_unless!(3 == foo2());
}