Stabilize impl_header_lifetime_elision in 2015 #54778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
scottmcm
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Centril
added
the
relnotes
|
☔ The latest upstream changes (presumably #54835) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Well, this found a bug in the feature 🙂 This is currently blocked by #54902 |
scottmcm
force-pushed
the
stabilize-ihle
branch
from
38d2c6e to
79b2d5a
Compare
|
Fixing the test failures, it looks like this stabilization will finally make this issue from 2014 work 🙂 |
This comment has been minimized.
This comment has been minimized.
scottmcm
force-pushed
the
stabilize-ihle
branch
from
f2006c8 to
5f77036
Compare
This comment has been minimized.
This comment has been minimized.
scottmcm
force-pushed
the
stabilize-ihle
branch
3 times, most recently
from
2308ac4 to
c0ede9d
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #54969) made this pull request unmergeable. Please resolve the merge conflicts. |
scottmcm
added
the
S-blocked
scottmcm
changed the title
scottmcm
removed
the
S-waiting-on-author
scottmcm
force-pushed
the
stabilize-ihle
branch
from
c0ede9d to
6f9b8e3
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #55134) made this pull request unmergeable. Please resolve the merge conflicts. |
It's already stable in 2018; this finishes the stabilization.
But its test was written in an outdated way that hits a different error despite IHLE, so keep a variant around for that case.
scottmcm
force-pushed
the
stabilize-ihle
branch
from
6f9b8e3 to
74df5ec
Compare
kennytm
added
S-waiting-on-review
scottmcm
changed the title
|
Ok, looks like this is finally ready for a review, @pnkfelix. Let me know if there's anything else I should change, or if you'd prefer that I squash some of the commits. |
|
@bors r+ |
|
📌 Commit 18f7db3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 23, 2018
Stabilize impl_header_lifetime_elision in 2015 ~~This is currently blocked on #54902; it should be good after that~~ It's already stable in 2018; this finishes the stabilization. FCP completed (#15872 (comment)), proposal (#15872 (comment)). Tracking issue: #15872 Usage examples (from libcore): #54687
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently blocked on #54902; it should be good after thatIt's already stable in 2018; this finishes the stabilization.
FCP completed (#15872 (comment)), proposal (#15872 (comment)).
Tracking issue: #15872
Usage examples (from libcore): #54687