-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move stage0.txt to toplevel directory #56285
Conversation
This way all files needed by packagers now reside in toplevel Signed-off-by: Marc-Antoine Perennou <[email protected]>
(rust_highfive has picked a reviewer for you, use r? to override) |
Is there a particular advantage to doing this? I wasn't aware that packagers cared too much about this -- I personally prefer to have as few top-level files as possible. |
@bors: r+ Eh I don't feel too strongly either way about this, so seems fine to me! |
📌 Commit c4e0b89 has been approved by |
move stage0.txt to toplevel directory This way all files needed by packagers now reside in toplevel
@bors rollup |
move stage0.txt to toplevel directory This way all files needed by packagers now reside in toplevel
@bors r- This failed |
Signed-off-by: Marc-Antoine Perennou <[email protected]>
@Mark-Simulacrum It's mainly to make things "easier" for packagers. We use this for bootstrapping. @kennytm should be fixed new |
@bors r=alexcrichton |
📌 Commit 610dcb4 has been approved by |
move stage0.txt to toplevel directory This way all files needed by packagers now reside in toplevel
@bors r- Caused the rollup to fail:
|
Well, it should have been a trivial change and it already made two rollups fail. Definitely not worth it to keep trying, sorry about that guys! |
This way all files needed by packagers now reside in toplevel