Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inline attributes and add unit to CommonTypes #56355

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Add inline attributes and add unit to CommonTypes #56355

merged 1 commit into from
Nov 30, 2018

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Nov 29, 2018

No description provided.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 29, 2018

@bors try

@bors
Copy link
Contributor

bors commented Nov 29, 2018

⌛ Trying commit 4cce4ff with merge f980b36...

bors added a commit that referenced this pull request Nov 29, 2018
@bors
Auto merge of #56355 - Zoxc:inline-things, r=<try>
f980b36 
Add inline attributes and add unit to CommonTypes
@bors
Copy link
Contributor

bors commented Nov 30, 2018

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 30, 2018

@rust-timer build f980b36

@rust-timer
Copy link
Collaborator

Please provide the full 40 character commit hash.

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 30, 2018

@rust-timer build f980b36

@rust-timer
Copy link
Collaborator

Success: Queued f980b36 with parent 3dde9e1, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit f980b36

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 30, 2018

Seems like a slight win.

r? @michaelwoerister

@michaelwoerister
Copy link
Member

@bors r+

Thanks @Zoxc! It's kinda sad that we still need these annotations although we have ThinLTO. Although I guess this is mostly because of using dylibs.

@bors
Copy link
Contributor

bors commented Nov 30, 2018

📌 Commit 4cce4ff has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018
@kennytm
Rollup merge of rust-lang#56355 - Zoxc:inline-things, r=michaelwoerister
551b1b9 
Add inline attributes and add unit to CommonTypes
@kennytm kennytm mentioned this pull request Nov 30, 2018
Closed
@kennytm kennytm mentioned this pull request Nov 30, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018
@kennytm
Rollup merge of rust-lang#56355 - Zoxc:inline-things, r=michaelwoerister
45aaaa7 
Add inline attributes and add unit to CommonTypes
bors added a commit that referenced this pull request Nov 30, 2018
@bors
Auto merge of #56381 - kennytm:rollup, r=kennytm
d09466c 
Rollup of 19 pull requests

Successful merges:

 - #55011 (Add libstd Cargo feature "panic_immediate_abort")
 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56131 (Assorted tweaks)
 - #56214 (Implement chalk unification routines)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56324 (Use raw_entry for more efficient interning)
 - #56336 (Clean up and streamline the pretty-printer)
 - #56337 (Fix const_fn ICE with non-const function pointer)
 - #56339 (Remove not used option)
 - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.)
 - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker)
 - #56355 (Add inline attributes and add unit to CommonTypes)
 - #56360 (Optimize local linkchecker program)
 - #56364 (Fix panic with outlives in existential type)
 - #56365 (Stabilize self_struct_ctor feature.)
 - #56367 (Moved some feature gate tests to correct location)
 - #56373 (Update books)
@bors bors merged commit 4cce4ff into rust-lang:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zoxc @rust-highfive @bors @rust-timer @michaelwoerister @davidtwco