[stable] Backport fixes to build-manifest #56960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builder is not really the correct place to put this, but it definitely has the time budget and checking this tool builds on just one platform is more than sufficient.
GPG versions 2.x+ require that --batch be passed if --passphrase-fd is to be accepted.
Apparently this changed with gpg2 or... something like that?
|
@bors r+ p=1000 |
|
📌 Commit 0a3f194 has been approved by |
bors
added
the
S-waiting-on-bors
pietroalbini
added
the
T-release
|
⌛ Testing commit 0a3f194 with merge a1d478bb0641cc3750b78043b31bbdb398f22dc0... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry please |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 18, 2018
[stable] Backport fixes to build-manifest Backports the following changes to stable: * #56703: Fix build of the `build-manifest` tool *(partial, just added last commit)* * #56783: Add `--pinentry-mode=loopback` to deployment script * #56735: Fix gpg signing in manifest builder r? @ghost cc @Mark-Simulacrum @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following changes to stable:
build-manifesttool #56703: Fix build of thebuild-manifesttool (partial, just added last commit)--pinentry-mode=loopbackto deployment script #56783: Add--pinentry-mode=loopbackto deployment scriptr? @ghost
cc @Mark-Simulacrum @alexcrichton