libcore: fix overflow/underflow in range_step #5769

gifnksm · 2013-04-07T11:48:23Z

uint::range_step or int::range_step causes overflow or underflow as following.
code:

fn main() {
    for uint::range_step(3, 0, -2) |n| {
        println(fmt!("%u", n));
    }
}

output:

3
1
18446744073709551615
18446744073709551613
...

This commit fixes this behavior as follows.

3
1

`uint::range_step` or `int::range_step` causes overflow or underflow as following. code: ```rust fn main() { for uint::range_step(3, 0, -2) |n| { println(fmt!("%u", n)); } } ``` output: ``` 3 1 18446744073709551615 18446744073709551613 ... ``` This commit fixes this behavior as follows. ``` 3 1 ```

…=phansch new lint: match_like_matches_macro Suggests using the `matches!` macro from `std` where appropriate. `redundant_pattern_matching` has been moved into the `matches` pass to allow suppressing the suggestion where `is_some` and friends are a better replacement. changelog: new lint: `match_like_matches_macro`

libcore: fix overflow/underflow in range_step

89676d6

bors closed this Apr 9, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libcore: fix overflow/underflow in range_step #5769

libcore: fix overflow/underflow in range_step #5769

gifnksm commented Apr 7, 2013

libcore: fix overflow/underflow in range_step #5769

libcore: fix overflow/underflow in range_step #5769

Conversation

gifnksm commented Apr 7, 2013