Fix some minor warnings #57764
Merged
Fix some minor warnings #57764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Xanewok
commented
Jan 19, 2019
| @@ -11,6 +11,7 @@ | |||
| test(attr(deny(warnings))))] | |||
|
|
|||
| #![feature(nll)] | |||
| #![feature(rustc_private)] | |||
There was a problem hiding this comment.
Due to is_xid_{start, continue}
Xanewok
commented
Jan 19, 2019
| @@ -25,7 +25,7 @@ | |||
| #![feature(asm)] | |||
| #![cfg_attr(stage0, feature(cfg_target_vendor))] | |||
| #![feature(fnbox)] | |||
| #![cfg_attr(any(unix, target_os = "cloudabi"), feature(libc))] | |||
| #![cfg_attr(any(unix, target_os = "cloudabi"), feature(libc, rustc_private))] | |||
There was a problem hiding this comment.
Any libc usage was warned against due to missing rustc_private annotation
nikomatsakis
approved these changes
Jan 25, 2019
|
@bors r+ rollup |
|
📌 Commit ff41abc has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 26, 2019
Fix some minor warnings Since apparently RLS works when initialized in the root repository (:tada:) I decided to fix some of the issues it caught. There are a lot of unused attribute warnings left on `rustc_on_unimplemented` and `rustc_layout_scalar_valid_range_start` but I imagine we can't do much about it due to 2-stage compilation?
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 26, 2019
Fix some minor warnings Since apparently RLS works when initialized in the root repository (:tada:) I decided to fix some of the issues it caught. There are a lot of unused attribute warnings left on `rustc_on_unimplemented` and `rustc_layout_scalar_valid_range_start` but I imagine we can't do much about it due to 2-stage compilation?
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 26, 2019
Fix some minor warnings Since apparently RLS works when initialized in the root repository (:tada:) I decided to fix some of the issues it caught. There are a lot of unused attribute warnings left on `rustc_on_unimplemented` and `rustc_layout_scalar_valid_range_start` but I imagine we can't do much about it due to 2-stage compilation?
bors
added a commit
that referenced
this pull request
Jan 26, 2019
Rollup of 7 pull requests Successful merges: - #57407 (Stabilize extern_crate_self) - #57703 (Make MutexGuard's Debug implementation more useful.) - #57764 (Fix some minor warnings) - #57825 (un-deprecate mem::zeroed) - #57827 (Ignore aarch64 in simd-intrinsic-generic-reduction) - #57908 (resolve: Fix span arithmetics in the import conflict error) - #57913 (Change crate-visibility-modifier issue number in The Unstable Book) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since apparently RLS works when initialized in the root repository (:tada:) I decided to fix some of the issues it caught.
There are a lot of unused attribute warnings left on
rustc_on_unimplementedandrustc_layout_scalar_valid_range_startbut I imagine we can't do much about it due to 2-stage compilation?