Removing some mutable fields and unsafe blocks #5787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the easier instances of mutable fields where the explicit self can just become
&mut self
along with removing some unsafe blocks which aren't necessary any more now that purity is gone.Most of #4568 is done, except for one case where it looks like it has to do with it being a
const
vector. Removing the unsafe block yields:I also didn't delve too much into removing mutable fields with
Cell
ortransmute
and friends.