Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile-pass test for #53606 #58479

Merged
merged 1 commit into from
Feb 17, 2019
Merged

compile-pass test for #53606 #58479

merged 1 commit into from
Feb 17, 2019

Conversation

saleemjaffer
Copy link
Contributor

@saleemjaffer saleemjaffer commented Feb 15, 2019 •
edited
Loading

fixes #53606

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2019
@saleemjaffer
Copy link
Contributor Author

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Feb 15, 2019

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Feb 15, 2019

📌 Commit 2c8e708 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Feb 15, 2019

Tip: if you change your main message to fixes #53606, then next time that issue will be closed automatically when the PR is merged

@saleemjaffer
Copy link
Contributor Author

@oli-obk Thanks! This is my first contribution to rust. Hoping to work on more difficult issues over time :)

@kennytm kennytm mentioned this pull request Feb 15, 2019
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Feb 16, 2019
@kennytm
Rollup merge of rust-lang#58479 - saleemjaffer:test_promote_evaluatio…
07b9833 
…n_unused_result, r=oli-obk

compile-pass test for rust-lang#53606

fixes rust-lang#53606
bors added a commit that referenced this pull request Feb 16, 2019
@bors
Auto merge of #58495 - kennytm:rollup, r=kennytm
f5f8284 
Rollup of 19 pull requests

Successful merges:

 - #57929 (Rustdoc remove old style files)
 - #57981 (Fix #57730)
 - #58074 (Stabilize slice_sort_by_cached_key)
 - #58196 (Add specific feature gate error for const-unstable features)
 - #58293 (Remove code for updating copyright years in generate-deriving-span-tests)
 - #58306 (Don't default on std crate when manipulating browser history)
 - #58359 (librustc_mir: use ? in impl_snapshot_for! macro)
 - #58395 (Instant::checked_duration_since)
 - #58429 (fix Box::into_unique effecitvely transmuting to a raw ptr)
 - #58433 (Update which libcore/liballoc tests Miri ignores, and document why)
 - #58438 (Use posix_spawn_file_actions_addchdir_np when possible)
 - #58440 (Whitelist the ARM v6 target-feature)
 - #58448 (rustdoc: mask `compiler_builtins` docs)
 - #58468 (split MaybeUninit into several features, expand docs a bit)
 - #58477 (Fix the syntax error in publish_toolstate.py)
 - #58479 (compile-pass test for #53606)
 - #58489 (Fix runtime error in generate-keyword-tests)
 - #58496 (Fix documentation for std::path::PathBuf::pop)
 - #58509 (Notify myself when Clippy toolstate changes)
kennytm added a commit to kennytm/rust that referenced this pull request Feb 17, 2019
@kennytm
Rollup merge of rust-lang#58479 - saleemjaffer:test_promote_evaluatio…
cfa6a70 
…n_unused_result, r=oli-obk

compile-pass test for rust-lang#53606

fixes rust-lang#53606
bors added a commit that referenced this pull request Feb 17, 2019
@bors
Auto merge of #58495 - kennytm:rollup, r=kennytm
8af675a 
Rollup of 19 pull requests

Successful merges:

 - #57929 (Rustdoc remove old style files)
 - #57981 (Fix #57730)
 - #58074 (Stabilize slice_sort_by_cached_key)
 - #58196 (Add specific feature gate error for const-unstable features)
 - #58293 (Remove code for updating copyright years in generate-deriving-span-tests)
 - #58306 (Don't default on std crate when manipulating browser history)
 - #58359 (librustc_mir: use ? in impl_snapshot_for! macro)
 - #58395 (Instant::checked_duration_since)
 - #58429 (fix Box::into_unique effecitvely transmuting to a raw ptr)
 - #58433 (Update which libcore/liballoc tests Miri ignores, and document why)
 - #58438 (Use posix_spawn_file_actions_addchdir_np when possible)
 - #58440 (Whitelist the ARM v6 target-feature)
 - #58448 (rustdoc: mask `compiler_builtins` docs)
 - #58468 (split MaybeUninit into several features, expand docs a bit)
 - #58479 (compile-pass test for #53606)
 - #58489 (Fix runtime error in generate-keyword-tests)
 - #58496 (Fix documentation for std::path::PathBuf::pop)
 - #58509 (Notify myself when Clippy toolstate changes)
 - #58521 (Fix tracking issue for error iterators)
@bors bors merged commit 2c8e708 into rust-lang:master Feb 17, 2019
@saleemjaffer saleemjaffer deleted the test_promote_evaluation_unused_result branch February 17, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NLL promotes arbitrary code to be evaluated by miri if the result is unused
5 participants
@saleemjaffer @rust-highfive @oli-obk @bors @nikomatsakis