Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: ensure VaList passes improper_ctypes lint #58938

Merged
merged 1 commit into from
Mar 16, 2019
Merged

core: ensure VaList passes improper_ctypes lint #58938

merged 1 commit into from
Mar 16, 2019

Conversation

dlrobertson
Copy link
Contributor

Ensure the core::ffi::VaList structure passes the improper_ctypes lint.

Fixes: #58280

@dlrobertson
core: ensure VaList passes improper_ctypes lint
1243859 
Ensure the core::ffi::VaList structure passes the improper_ctypes lint.
@rust-highfive
Copy link
Collaborator

r? @bluss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2019
@Centril
Copy link
Contributor

Centril commented Mar 5, 2019

r? @joshtriplett

@rust-highfive rust-highfive assigned joshtriplett and unassigned bluss Mar 5, 2019
@dlrobertson
Copy link
Contributor Author

Note the alternative is to make VaList always pass the lint as mentioned here. I chose to go this route, as improper ctypes probably shouldn't be used in VaList.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 6, 2019

📌 Commit 1243859 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
@Centril
Rollup merge of rust-lang#58938 - dlrobertson:fix_58280, r=joshtriplett
e840d55 
core: ensure VaList passes improper_ctypes lint

Ensure the `core::ffi::VaList` structure passes the `improper_ctypes` lint.

Fixes: rust-lang#58280
@Centril Centril mentioned this pull request Mar 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
@Centril
Rollup merge of rust-lang#58938 - dlrobertson:fix_58280, r=joshtriplett
091266b 
core: ensure VaList passes improper_ctypes lint

Ensure the `core::ffi::VaList` structure passes the `improper_ctypes` lint.

Fixes: rust-lang#58280
@Centril Centril mentioned this pull request Mar 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
@Centril
Rollup merge of rust-lang#58938 - dlrobertson:fix_58280, r=joshtriplett
f261445 
core: ensure VaList passes improper_ctypes lint

Ensure the `core::ffi::VaList` structure passes the `improper_ctypes` lint.

Fixes: rust-lang#58280
@Centril Centril mentioned this pull request Mar 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
@Centril
Rollup merge of rust-lang#58938 - dlrobertson:fix_58280, r=joshtriplett
0947edc 
core: ensure VaList passes improper_ctypes lint

Ensure the `core::ffi::VaList` structure passes the `improper_ctypes` lint.

Fixes: rust-lang#58280
@Centril Centril mentioned this pull request Mar 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2019
@Centril
Rollup merge of rust-lang#58938 - dlrobertson:fix_58280, r=joshtriplett
d0ab135 
core: ensure VaList passes improper_ctypes lint

Ensure the `core::ffi::VaList` structure passes the `improper_ctypes` lint.

Fixes: rust-lang#58280
@Centril Centril mentioned this pull request Mar 11, 2019
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 11, 2019
@kennytm
Rollup merge of rust-lang#58938 - dlrobertson:fix_58280, r=joshtriplett
d254739 
core: ensure VaList passes improper_ctypes lint

Ensure the `core::ffi::VaList` structure passes the `improper_ctypes` lint.

Fixes: rust-lang#58280
@kennytm kennytm mentioned this pull request Mar 11, 2019
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 15, 2019
@kennytm
Rollup merge of rust-lang#58938 - dlrobertson:fix_58280, r=joshtriplett
3d305f9 
core: ensure VaList passes improper_ctypes lint

Ensure the `core::ffi::VaList` structure passes the `improper_ctypes` lint.

Fixes: rust-lang#58280
@kennytm kennytm mentioned this pull request Mar 15, 2019
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 16, 2019
@kennytm
Rollup merge of rust-lang#58938 - dlrobertson:fix_58280, r=joshtriplett
5e232b3 
core: ensure VaList passes improper_ctypes lint

Ensure the `core::ffi::VaList` structure passes the `improper_ctypes` lint.

Fixes: rust-lang#58280
@kennytm kennytm mentioned this pull request Mar 16, 2019
Merged
bors added a commit that referenced this pull request Mar 16, 2019
@bors
Auto merge of #59226 - kennytm:rollup, r=kennytm
2c8bbf5 
Rollup of 37 pull requests

Successful merges:

 - #58854 (appveyor: Use VS2017 for all our images)
 - #58855 (std: Spin for a global malloc lock on wasm32)
 - #58873 (Fix "Auto-hide item methods documentation" setting)
 - #58901 (Change `std::fs::copy` to use `copyfile` on MacOS and iOS)
 - #58933 (Move alloc::prelude::* to alloc::prelude::v1, make alloc a subset of std)
 - #58938 (core: ensure VaList passes improper_ctypes lint)
 - #58941 (MIPS: add r6 support)
 - #58949 (SGX target: Expose thread id function in os module)
 - #58959 (Add release notes for PR #56243)
 - #58976 (Default to integrated `rust-lld` linker for UEFI targets)
 - #59009 (Fix SGX implementations of read/write_vectored.)
 - #59025 (Fix generic argument lookup for Self)
 - #59036 (Fix ICE in MIR pretty printing)
 - #59037 (Avoid some common false positives in intra doc link checking)
 - #59072 (we can now skip should_panic tests with the libtest harness)
 - #59079 (add suggestions to invalid macro item error)
 - #59082 (A few improvements to comments in user-facing crates)
 - #59102 (Consistent naming for duration_float methods and additional f32 methods)
 - #59118 (rustc: fix ICE when trait alias has bare Self)
 - #59139 (Unregress using scalar unions in constants.)
 - #59146 (Suggest return lifetime when there's only one named lifetime)
 - #59147 (Make std time tests more robust for platform differences)
 - #59152 (Stabilize Range*::contains.)
 - #59156 ([wg-async-await] Add regression test for #55809.)
 - #59158 (Revert "Don't generate minification variable if minification disabled")
 - #59169 (Add `-Z allow_features=...` flag)
 - #59173 (bootstrap: Default to a sensible llvm-suffix.)
 - #59175 (Don't run test launching `echo` since that doesn't exist on Windows)
 - #59180 (Use try blocks in rustc_codegen_ssa)
 - #59185 (No old chestnuts in iter::repeat docs)
 - #59201 (Remove restriction on isize/usize in repr(simd))
 - #59204 (Output diagnostic information for rustdoc)
 - #59206 (Improved test output)
 - #59208 (Reduce a Code Repetition Related to Bit Operation)
 - #59212 (Add x86_64 musl host to the manifest)
 - #59221 (Option and Result: Add references to documentation of as_ref and as_mut)
 - #59231 (Stabilize Option::copied)
@bors bors merged commit 1243859 into rust-lang:master Mar 16, 2019
@dlrobertson dlrobertson deleted the fix_58280 branch March 16, 2019 21:15
@workingjubilee workingjubilee added the F-c_variadic `#![feature(c_variadic)]` label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
F-c_variadic `#![feature(c_variadic)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core::ffi::VaList does not pass improper_ctypes lint
7 participants
@dlrobertson @rust-highfive @Centril @joshtriplett @bors @bluss @workingjubilee