Normalize use of backticks compiler messages #61901

fakenine · 2019-06-16T20:27:24Z

Normalize use of backticks compiler messages

rust-highfive · 2019-06-16T20:27:28Z

Some changes occurred in diagnostic error codes

rust-highfive · 2019-06-16T20:27:29Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive · 2019-06-16T20:37:29Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:240e6bcb:start=1560716902460829436,finish=1560716991319590918,duration=88858761482
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:03:50] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:51] tidy error: /checkout/src/librustc/hir/lowering.rs:1667: line longer than 100 chars
[00:03:55] some tidy checks failed
[00:03:55] 
[00:03:55] 
[00:03:55] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:55] 
[00:03:55] 
[00:03:55] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:55] Build completed unsuccessfully in 0:01:13
---
travis_time:end:08ca1c77:start=1560717237484799443,finish=1560717237489814304,duration=5014861
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2191c0f2
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05b74c1c
travis_time:start:05b74c1c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:22d47e6c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/librustc/hir/lowering.rs

alexreg · 2019-06-17T14:53:54Z

r? @alexreg

alexreg

Looks good, apart from the two very minor comments. Thanks a lot for this!

src/librustc/hir/lowering.rs

src/librustc_passes/rvalue_promotion.rs

alexreg · 2019-06-17T15:11:54Z

I haven't checked it myself yet, but can you make sure that literal values are all quoted too? i.e., strings, numbers, bools, so you have (e.g.) `true`.

Actually, this can look kind of awkward with strings, e.g., `"foo"`. Even though it would be most consistent. What do you think @Centril?

Centril · 2019-06-17T17:39:10Z

Actually, this can look kind of awkward with strings, e.g., `"foo"`. Even though it would be most consistent. What do you think @Centril?

Seems fine to me.

bors · 2019-06-20T10:54:20Z

☔ The latest upstream changes (presumably #61983) made this pull request unmergeable. Please resolve the merge conflicts.

fakenine · 2019-06-21T21:17:26Z

Hello @alexreg! I have updated the PR. Unfortunately, I haven't been able to find debug messages with literal values that are not quoted...But maybe my regexes weren't accurate.

For this PR, I've squashed the 3 commits into one. Would you prefer 3 seperate commits for easier review? (especially for the last big commit where the tests were update by the x.py command)

rust-highfive · 2019-06-21T22:19:19Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:02dd8b0c:start=1561151670851845201,finish=1561151673513485618,duration=2661640417
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:58:49] .................................................................................................... 400/2920
[00:58:58] .................................................................................................... 500/2920
[00:59:10] .................................................................................................... 600/2920
[00:59:24] .................................................................................................... 700/2920
[00:59:35] ...................F..F............................................................................. 800/2920
[00:59:44] .................................................................................................... 900/2920
[00:59:58] ............................F....................................................................... 1000/2920
[01:00:19] .................................................................................................... 1200/2920
[01:00:29] .................................................................................................... 1300/2920
[01:00:41] ....................ii.............................................................................. 1400/2920
[01:00:52] .................................................................................................... 1500/2920
[01:00:52] .................................................................................................... 1500/2920
[01:01:01] .........................................................................i......i................... 1600/2920
[01:01:15] .................................................................................................... 1700/2920
[01:01:28] .................................................................................................... 1800/2920
[01:01:39] ..............F..................................................................................... 1900/2920
[01:02:21] .................................................................................................... 2100/2920
[01:02:41] .......................................................................test [run-pass] run-pass/mpsc_stress.rs has been running for over 60 seconds
[01:02:43] ............................. 2200/2920
[01:02:43] ............................. 2200/2920
[01:02:54] ......................................................................FF............................ 2300/2920
[01:03:22] .................................................................................................... 2500/2920
[01:03:54] .................................................................................................... 2600/2920
[01:04:03] .................................................................................................... 2700/2920
[01:04:13] .................................................................................................... 2800/2920
[01:04:13] .................................................................................................... 2800/2920
[01:04:25] .................................................................................................... 2900/2920
[01:04:28] ....................
[01:04:28] failures:
[01:04:28] 
[01:04:28] ---- [run-pass] run-pass/extern/extern-prelude-core.rs stdout ----
[01:04:28] diff of stderr:
[01:04:28] 
[01:04:28] 4 LL | #![feature(extern_prelude, lang_items, start)]
[01:04:28] 6    |
[01:04:28] -    = note: #[warn(stable_features)] on by default
[01:04:28] -    = note: #[warn(stable_features)] on by default
[01:04:28] +    = note: `#[warn(stable_features)]` on by default
[01:04:28] 9 
[01:04:28] 
[01:04:28] 
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern/extern-prelude-core/extern-prelude-core.stderr
[01:04:28] To update references, rerun the tests and pass the `--bless` flag
[01:04:28] To only update this specific test, also pass `--test-args extern/extern-prelude-core.rs`
[01:04:28] error: 1 errors occurred comparing output.
[01:04:28] status: exit code: 0
[01:04:28] status: exit code: 0
[01:04:28] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/extern/extern-prelude-core.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern/extern-prelude-core/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern/extern-prelude-core/auxiliary"
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] stderr:
[01:04:28] stderr:
[01:04:28] ------------------------------------------
[01:04:28] warning: the feature `extern_prelude` has been stable since 1.30.0 and no longer requires an attribute to enable
[01:04:28]   --> /checkout/src/test/run-pass/extern/extern-prelude-core.rs:2:12
[01:04:28]    |
[01:04:28] LL | #![feature(extern_prelude, lang_items, start)]
[01:04:28]    |
[01:04:28]    |
[01:04:28]    = note: `#[warn(stable_features)]` on by default
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] 
[01:04:28] 
[01:04:28] ---- [run-pass] run-pass/extern/extern-prelude-std.rs stdout ----
[01:04:28] diff of stderr:
[01:04:28] 
[01:04:28] 4 LL | #![feature(extern_prelude)]
[01:04:28] 5    |            ^^^^^^^^^^^^^^
[01:04:28] 6    |
[01:04:28] -    = note: #[warn(stable_features)] on by default
[01:04:28] +    = note: `#[warn(stable_features)]` on by default
[01:04:28] 9 
[01:04:28] 
[01:04:28] 
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern/extern-prelude-std/extern-prelude-std.stderr
[01:04:28] To update references, rerun the tests and pass the `--bless` flag
[01:04:28] To only update this specific test, also pass `--test-args extern/extern-prelude-std.rs`
[01:04:28] error: 1 errors occurred comparing output.
[01:04:28] status: exit code: 0
[01:04:28] status: exit code: 0
[01:04:28] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/extern/extern-prelude-std.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern/extern-prelude-std/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern/extern-prelude-std/auxiliary"
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] stderr:
[01:04:28] stderr:
[01:04:28] ------------------------------------------
[01:04:28] warning: the feature `extern_prelude` has been stable since 1.30.0 and no longer requires an attribute to enable
[01:04:28]   --> /checkout/src/test/run-pass/extern/extern-prelude-std.rs:2:12
[01:04:28]    |
[01:04:28] LL | #![feature(extern_prelude)]
[01:04:28]    |            ^^^^^^^^^^^^^^
[01:04:28]    |
[01:04:28]    = note: `#[warn(stable_features)]` on by default
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] 
[01:04:28] 
[01:04:28] ---- [run-pass] run-pass/if-ret.rs stdout ----
[01:04:28] diff of stderr:
[01:04:28] 
[01:04:28] 4 LL | fn foo() { if (return) { } }
[01:04:28] 6    |
[01:04:28] -    = note: #[warn(unreachable_code)] on by default
[01:04:28] -    = note: #[warn(unreachable_code)] on by default
[01:04:28] +    = note: `#[warn(unreachable_code)]` on by default
[01:04:28] 9 
[01:04:28] 
[01:04:28] 
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/if-ret/if-ret.stderr
[01:04:28] To update references, rerun the tests and pass the `--bless` flag
[01:04:28] To only update this specific test, also pass `--test-args if-ret.rs`
[01:04:28] error: 1 errors occurred comparing output.
[01:04:28] status: exit code: 0
[01:04:28] status: exit code: 0
[01:04:28] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/if-ret.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/if-ret/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/if-ret/auxiliary"
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] stderr:
[01:04:28] stderr:
[01:04:28] ------------------------------------------
[01:04:28] warning: unreachable block in `if` expression
[01:04:28]   --> /checkout/src/test/run-pass/if-ret.rs:4:24
[01:04:28]    |
[01:04:28] LL | fn foo() { if (return) { } }
[01:04:28]    |
[01:04:28]    |
[01:04:28]    = note: `#[warn(unreachable_code)]` on by default
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] 
[01:04:28] 
[01:04:28] ---- [run-pass] run-pass/macros/macro-use-all-and-none.rs stdout ----
[01:04:28] diff of stderr:
[01:04:28] 
[01:04:28] 4 LL | #[macro_use()]
[01:04:28] 5    | ^^^^^^^^^^^^^^
[01:04:28] 6    |
[01:04:28] -    = note: #[warn(unused_attributes)] on by default
[01:04:28] +    = note: `#[warn(unused_attributes)]` on by default
[01:04:28] 9 
[01:04:28] 
[01:04:28] 
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/macros/macro-use-all-and-none/macro-use-all-and-none.stderr
[01:04:28] To update references, rerun the tests and pass the `--bless` flag
[01:04:28] To only update this specific test, also pass `--test-args macros/macro-use-all-and-none.rs`
[01:04:28] error: 1 errors occurred comparing output.
[01:04:28] status: exit code: 0
[01:04:28] status: exit code: 0
[01:04:28] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/macros/macro-use-all-and-none.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/macros/macro-use-all-and-none/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/macros/macro-use-all-and-none/auxiliary"
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] stderr:
[01:04:28] stderr:
[01:04:28] ------------------------------------------
[01:04:28] warning: unused attribute
[01:04:28]   --> /checkout/src/test/run-pass/macros/macro-use-all-and-none.rs:5:1
[01:04:28]    |
[01:04:28] LL | #[macro_use()]
[01:04:28]    | ^^^^^^^^^^^^^^
[01:04:28]    |
[01:04:28]    = note: `#[warn(unused_attributes)]` on by default
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] 
[01:04:28] 
[01:04:28] ---- [run-pass] run-pass/rfcs/rfc-2126-crate-paths/crate-path-visibility-ambiguity.rs stdout ----
[01:04:28] diff of stderr:
[01:04:28] 
[01:04:28] 4 LL | #![feature(crate_in_paths)]
[01:04:28] 5    |            ^^^^^^^^^^^^^^
[01:04:28] 6    |
[01:04:28] -    = note: #[warn(stable_features)] on by default
[01:04:28] +    = note: `#[warn(stable_features)]` on by default
[01:04:28] 9 
[01:04:28] 
[01:04:28] 
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-visibility-ambiguity/crate-path-visibility-ambiguity.stderr
[01:04:28] To update references, rerun the tests and pass the `--bless` flag
[01:04:28] To only update this specific test, also pass `--test-args rfcs/rfc-2126-crate-paths/crate-path-visibility-ambiguity.rs`
[01:04:28] error: 1 errors occurred comparing output.
[01:04:28] status: exit code: 0
[01:04:28] status: exit code: 0
[01:04:28] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-visibility-ambiguity.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-visibility-ambiguity/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-visibility-ambiguity/auxiliary"
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] stderr:
[01:04:28] stderr:
[01:04:28] ------------------------------------------
[01:04:28] warning: the feature `crate_in_paths` has been stable since 1.30.0 and no longer requires an attribute to enable
[01:04:28]   --> /checkout/src/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-visibility-ambiguity.rs:2:12
[01:04:28]    |
[01:04:28] LL | #![feature(crate_in_paths)]
[01:04:28]    |            ^^^^^^^^^^^^^^
[01:04:28]    |
[01:04:28]    = note: `#[warn(stable_features)]` on by default
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] 
[01:04:28] 
[01:04:28] ---- [run-pass] run-pass/rfcs/rfc-2126-crate-paths/crate-path-absolute.rs stdout ----
[01:04:28] diff of stderr:
[01:04:28] 
[01:04:28] 4 LL | #![feature(crate_in_paths)]
[01:04:28] 5    |            ^^^^^^^^^^^^^^
[01:04:28] 6    |
[01:04:28] -    = note: #[warn(stable_features)] on by default
[01:04:28] +    = note: `#[warn(stable_features)]` on by default
[01:04:28] 9 
[01:04:28] 
[01:04:28] 
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] The actual stderr differed from the expected stderr.
[01:04:28] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-absolute/crate-path-absolute.stderr
[01:04:28] To update references, rerun the tests and pass the `--bless` flag
[01:04:28] To only update this specific test, also pass `--test-args rfcs/rfc-2126-crate-paths/crate-path-absolute.rs`
[01:04:28] error: 1 errors occurred comparing output.
[01:04:28] status: exit code: 0
[01:04:28] status: exit code: 0
[01:04:28] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-absolute.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-absolute/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-absolute/auxiliary"
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] stderr:
[01:04:28] stderr:
[01:04:28] ------------------------------------------
[01:04:28] warning: the feature `crate_in_paths` has been stable since 1.30.0 and no longer requires an attribute to enable
[01:04:28]   --> /checkout/src/test/run-pass/rfcs/rfc-2126-crate-paths/crate-path-absolute.rs:2:12
[01:04:28]    |
[01:04:28] LL | #![feature(crate_in_paths)]
[01:04:28]    |            ^^^^^^^^^^^^^^
[01:04:28]    |
[01:04:28]    = note: `#[warn(stable_features)]` on by default
[01:04:28] 
[01:04:28] ------------------------------------------
[01:04:28] 
[01:04:28] 
---
[01:04:28] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[01:04:28] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:04:28] 
[01:04:28] 
[01:04:28] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:04:28] 
[01:04:28] 
[01:04:28] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:04:28] Build completed unsuccessfully in 0:59:43
---
travis_time:end:28e5262d:start=1561155554682216443,finish=1561155554687239904,duration=5023461
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00c697bf
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1b5e3dd0
travis_time:start:1b5e3dd0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0f617ff8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexreg · 2019-06-21T23:23:13Z

@fakenine Thanks a lot. Yes, 3 separate commits would be best. I already reviewed the first one (presuming you didn't amend it), so that would save time.

As for literal values, probably this will have to be done manually I'm afraid. But the good news is there are probably many fewer examples of this. Maybe identify them from .stderr/.stdout files to get the full error messages, then search for them?

Looks like you forgot to bless the run-pass tests BTW. :-)

bors · 2019-06-23T20:17:16Z

☔ The latest upstream changes (presumably #61778) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2019-07-01T06:44:16Z

☔ The latest upstream changes (presumably #61682) made this pull request unmergeable. Please resolve the merge conflicts.

alexreg · 2019-07-01T17:08:21Z

@fakenine Looks like there's just a few more ui tests to bless... if you could do that, fix the little conflict (just rebase and bless the corresponding test), and make the small change I commented on, I'll review and hopefully we can get this merged. :-)

fakenine · 2019-07-01T21:12:38Z

Hello @alexreg! Thank you for the feedback :) I'll bless the remaining tests and apply the requested changes (blessing takes the most time because my computer takes quite a long time to build hehe). I will notify you when everything is ready for me!

alexreg

Overall very good.

src/librustc/session/config.rs

src/librustc_codegen_utils/link.rs

src/libsyntax/feature_gate.rs

src/librustc/middle/resolve_lifetime.rs

src/librustc_data_structures/flock.rs

src/libsyntax/parse/attr.rs

alexreg · 2019-07-02T01:02:29Z

Great, thanks. Just a few more things to address (pre-existing, so not your fault), and we're good to go. If you have trouble blessing all the tests ./x.py test --bless should do it (make sure you run it a second time with --compare-mode=nll) – or it's simply taking you too long – let me know and I can give it a go.

As for building, yeah, it's a pain... make sure you do ./x.py your_cmd -i --keep-stage 0 to speed things up though, and maybe consider the GCC build farm.

fakenine · 2019-07-05T20:57:32Z

@alexreg Oops! My bad, that's noted for next time. I'll fix this

alexreg · 2019-07-05T21:17:30Z

@fakenine I’d already fixed it myself before posting that comment.

bors · 2019-07-05T21:54:08Z

☔ The latest upstream changes (presumably #62419) made this pull request unmergeable. Please resolve the merge conflicts.

alexreg · 2019-07-05T22:55:21Z

@bors r+

bors · 2019-07-05T22:55:22Z

📌 Commit 4448b27 has been approved by alexreg

bors · 2019-07-06T00:31:26Z

⌛ Testing commit 4448b27 with merge c62d6f0f62b481e7078f8cdc85adfe9087a606e8...

Centril · 2019-07-06T00:42:00Z

Tests seem to have failed in the PR builder so @bors r- retry

Please consider breaking this PR up into several independent pieces.
It makes the chances of conflicts and problems with various other PRs much lower.

alexreg · 2019-07-06T01:05:40Z

@fakenine Looks like some recent merges created new tests that need blessing... sorry! https://dev.azure.com/rust-lang/rust/_build/results?buildId=2537

alexreg · 2019-07-06T02:25:49Z

@bors delegate=fakenine

You can now r+ it in a similar manner to how I did above, once you've reblessed the tests. (Make sure you pull my latest version from your branch before you edit it though.) Maybe ping @Centril once you've r+'ed too, in case I'm not around. He can make sure it gets through without further conflicts.. hopefully!

bors · 2019-07-06T02:25:50Z

✌️ @fakenine can now approve this pull request

Mark-Simulacrum · 2019-07-06T02:46:11Z

Note: please do @ bors r=alexreg and not @ bors r+, since the latter will incorrectly approve this PR in your name, not alexreg's. The spaces here shouldn't be replicated, that's merely because bors is very eager in finding invocations to it.

alexreg · 2019-07-06T02:50:12Z

Yes sorry, @Mark-Simulacrum is right. It's very late here. -_-

fakenine · 2019-07-06T07:12:54Z

@Centril I’ll do that. I’m closing this PR and will split it to avoid multiple rebasings and conflicts

rust-highfive assigned cramertj Jun 16, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2019

fakenine mentioned this pull request Jun 16, 2019

Normalize use of backticks in syntax for user-facing compiler messages #60532

Closed

Centril reviewed Jun 16, 2019

View reviewed changes

src/librustc/hir/lowering.rs Outdated Show resolved Hide resolved

rust-highfive assigned alexreg and unassigned cramertj Jun 17, 2019

alexreg reviewed Jun 17, 2019

View reviewed changes

src/librustc/hir/lowering.rs Outdated Show resolved Hide resolved

src/librustc_passes/rvalue_promotion.rs Outdated Show resolved Hide resolved

fakenine force-pushed the normalize_use_of_backticks_compiler_messages branch from 52f9b9e to 70ee2f4 Compare June 19, 2019 20:40

fakenine force-pushed the normalize_use_of_backticks_compiler_messages branch from 70ee2f4 to 30c1362 Compare June 21, 2019 21:00

fakenine changed the title ~~WIP: Normalize use of backticks compiler messages~~ Normalize use of backticks compiler messages Jun 21, 2019

fakenine force-pushed the normalize_use_of_backticks_compiler_messages branch from 30c1362 to 6682487 Compare June 21, 2019 21:13

fakenine force-pushed the normalize_use_of_backticks_compiler_messages branch from 6682487 to d82c598 Compare June 30, 2019 20:09

fakenine force-pushed the normalize_use_of_backticks_compiler_messages branch from d82c598 to 6009ab8 Compare July 1, 2019 21:54

alexreg suggested changes Jul 2, 2019

View reviewed changes

src/librustc/session/config.rs Outdated Show resolved Hide resolved

src/librustc/session/config.rs Outdated Show resolved Hide resolved

src/librustc_codegen_utils/link.rs Outdated Show resolved Hide resolved

src/libsyntax/feature_gate.rs Outdated Show resolved Hide resolved

alexreg suggested changes Jul 2, 2019

View reviewed changes

src/librustc/middle/resolve_lifetime.rs Show resolved Hide resolved

src/librustc_data_structures/flock.rs Outdated Show resolved Hide resolved

src/libsyntax/parse/attr.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 5, 2019

Samy Kacimi added 8 commits July 5, 2019 23:48

doc: normalize use of backticks in compiler messages

5b9a51f

normalize use of backticks in compiler messages

f895ef8

begin debug! message with a lowercase

07762a1

update tests following backticks modification of compiler messages

e3da30e

add space either side of / in unchecked_dirty_clean.rs test

3381009

bless ui-fulldeps tests

cd5214c

fix syntax typos and consistency in compiler messages

4c91dc2

bless rustdoc-ui and ui tests

4448b27

alexreg force-pushed the normalize_use_of_backticks_compiler_messages branch from 00bfb8d to 4448b27 Compare July 5, 2019 22:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2019

fakenine closed this Jul 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normalize use of backticks compiler messages #61901

Normalize use of backticks compiler messages #61901

fakenine commented Jun 16, 2019

rust-highfive commented Jun 16, 2019

rust-highfive commented Jun 16, 2019

rust-highfive commented Jun 16, 2019

alexreg commented Jun 17, 2019

alexreg left a comment

alexreg commented Jun 17, 2019 •

edited

Loading

Centril commented Jun 17, 2019

bors commented Jun 20, 2019

fakenine commented Jun 21, 2019 •

edited

Loading

rust-highfive commented Jun 21, 2019

alexreg commented Jun 21, 2019

bors commented Jun 23, 2019

bors commented Jul 1, 2019

alexreg commented Jul 1, 2019

fakenine commented Jul 1, 2019 •

edited

Loading

alexreg left a comment

alexreg commented Jul 2, 2019

fakenine commented Jul 5, 2019

alexreg commented Jul 5, 2019

bors commented Jul 5, 2019

alexreg commented Jul 5, 2019

bors commented Jul 5, 2019

bors commented Jul 6, 2019

Centril commented Jul 6, 2019

alexreg commented Jul 6, 2019

alexreg commented Jul 6, 2019

bors commented Jul 6, 2019

Mark-Simulacrum commented Jul 6, 2019

alexreg commented Jul 6, 2019

fakenine commented Jul 6, 2019

Normalize use of backticks compiler messages #61901

Normalize use of backticks compiler messages #61901

Conversation

fakenine commented Jun 16, 2019

rust-highfive commented Jun 16, 2019

rust-highfive commented Jun 16, 2019

rust-highfive commented Jun 16, 2019

alexreg commented Jun 17, 2019

alexreg left a comment

Choose a reason for hiding this comment

alexreg commented Jun 17, 2019 • edited Loading

Centril commented Jun 17, 2019

bors commented Jun 20, 2019

fakenine commented Jun 21, 2019 • edited Loading

rust-highfive commented Jun 21, 2019

alexreg commented Jun 21, 2019

bors commented Jun 23, 2019

bors commented Jul 1, 2019

alexreg commented Jul 1, 2019

fakenine commented Jul 1, 2019 • edited Loading

alexreg left a comment

Choose a reason for hiding this comment

alexreg commented Jul 2, 2019

fakenine commented Jul 5, 2019

alexreg commented Jul 5, 2019

bors commented Jul 5, 2019

alexreg commented Jul 5, 2019

bors commented Jul 5, 2019

bors commented Jul 6, 2019

Centril commented Jul 6, 2019

alexreg commented Jul 6, 2019

alexreg commented Jul 6, 2019

bors commented Jul 6, 2019

Mark-Simulacrum commented Jul 6, 2019

alexreg commented Jul 6, 2019

fakenine commented Jul 6, 2019

alexreg commented Jun 17, 2019 •

edited

Loading

fakenine commented Jun 21, 2019 •

edited

Loading

fakenine commented Jul 1, 2019 •

edited

Loading