Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a crt-debug target feature #62534

Closed
wants to merge 1 commit into from
Closed

Add a crt-debug target feature #62534

wants to merge 1 commit into from

Conversation

jdm
Copy link
Contributor

@jdm jdm commented Jul 9, 2019

This feature is designed to address #39016 but it has the curious property that it does not actually affect the behaviour of rustc's linking at all. Ultimately it's used to modify which CRT is linked by libc, much like the crt-static target feature.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2019
@alexcrichton
Copy link
Member

FWIW the crt-static feature went through an RFC. This PR seems pretty light on details and meat in general relative to that?

It would be good to at minimum include some tests which exercise this, for example ensuring that if C code is compiled on MSVC against the debug runtime that it works correctly when linked into Rust. This would likely also want to be added to documentation, probably around where crt-static is mentioned. I think we'll likely want to gate this to nightly to start out with as well since it's a new feature.

@totsteps
Copy link
Member

ping from triage @eddyb any updates on the review?

Since alexcrichton left some comments, @jdm any opinions?

@jdm
Copy link
Contributor Author

jdm commented Jul 23, 2019

I'm going to close this until I've been able to verify that it actually addresses the use case that I care about.

@jdm jdm closed this Jul 23, 2019
@eddyb
Copy link
Member

eddyb commented Jul 25, 2019

@gagan0723 Sorry, forgot to reassign.

r? @alexcrichton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants