-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display name of crate requiring rustc_private in error messages. #62819
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@@ -12,4 +12,5 @@ use rustc_macros::HashStable; | |||
|
|||
#[derive(HashStable)] | |||
//~^ use of unstable library feature 'rustc_private' | |||
//~| use of unstable library feature 'rustc_private' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason for this duplicate line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those directives match the start of an error message. Both error messages start the same, but then contain a different crate being loaded from the sysroot: crate "rustc_data_structures" is being from the sysroot, [...]
and crate "rustc" is being from the sysroot, [...]
.
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
r? @oli-obk |
Co-Authored-By: Igor Matuszewski <[email protected]>
@bors r+ |
📌 Commit 6a26b80 has been approved by |
@oli-obk Mind roll up this too? |
Display name of crate requiring rustc_private in error messages. This is extraction and rebase of one part of rust-lang#59440 that doesn't involve external things. r? @oli-obk
Rollup of 10 pull requests Successful merges: - rust-lang#60938 (rustdoc: make #[doc(include)] relative to the containing file) - rust-lang#61890 (Fix some sanity checks) - rust-lang#62261 (Take substs into account in `conservative_is_privately_uninhabited`) - rust-lang#62528 (Add joining slices of slices with a slice separator, not just a single item) - rust-lang#62735 (Turn `#[global_allocator]` into a regular attribute macro) - rust-lang#62801 (Remove support for -Zlower-128bit-ops) - rust-lang#62808 (Revert "Disable stack probing for gnux32.") - rust-lang#62819 (Display name of crate requiring rustc_private in error messages.) - rust-lang#62904 (Disable d32 on armv6 hf targets) - rust-lang#62907 (Initialize the MSP430 AsmParser) Failed merges: r? @ghost
@bors r- This needs a rebase and changes to the error message here: https://github.com/rust-lang/rust/blob/master/src/test/ui/feature-gate/rustc-private.rs EDIT: Ah, just a |
ping from triage @crlf0710, could you address the reviewer's comment? |
According to recent plans for stablizing |
This is extraction and rebase of one part of #59440 that doesn't involve external things.
r? @oli-obk