-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a pair of whitespace after remove parentheses #63163
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I don't think we should add the spaces unconditionally, since that would cause there to be double-spaces in the code that most folks probably tried to write: |
Would be good to add a regression test also. |
OK. I will check the position of |
I add some conditional spaces. But there is a problem, I can't find the |
This comment has been minimized.
This comment has been minimized.
Tidy problem is fixed. |
Can this pull request be merged or there are other problems to be fixed? @cramertj |
It looks good to me, although it'd be great to add a rustfix test, to make sure that our suggestions are being applied correctly. r=me with that change. |
r? @cramertj |
r= @cramertj |
@bors r+ |
📌 Commit 3a95c71 has been approved by |
add a pair of whitespace after remove parentheses fix [issue-63156](rust-lang#63156). add a pair of whitespace after remove parentheses.
Rollup of 9 pull requests Successful merges: - #63034 (Fix generator size regressions due to optimization) - #63035 (Use MaybeUninit to produce more correct layouts) - #63163 (add a pair of whitespace after remove parentheses) - #63294 (tests for async/await drop order) - #63307 (don't ignore mir_dump folder) - #63308 (PlaceRef's base is already a reference) - #63310 (Tests around moving parts of structs and tuples across await points) - #63314 (doc: the content has since been moved to the guide) - #63333 (Remove unnecessary features from compiler error code list) Failed merges: r? @ghost
fix issue-63156.
add a pair of whitespace after remove parentheses.