Use libunwind from llvm-project submodule for musl targets #63173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Nice! Definitely seems like a nice extension of what we have already. I think though this may need to keep the |
|
(it may also be worthwhile to enable temporarily for this PR the builders exercising musl tests to ensure those still work) |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
malbarbo
force-pushed
the
musl-libunwind
branch
from
5c8eba2 to
bad8b39
Compare
malbarbo
changed the title
|
I tested it locally and was able to produce static and dynamic binaries. I also enabled test-various, which run musl tests. |
|
☔ The latest upstream changes (presumably #63242) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Looks great to me! r=me with the PR cleaned up slightly |
malbarbo
force-pushed
the
musl-libunwind
branch
from
bad8b39 to
e54b575
Compare
|
@malbarbo: 🔑 Insufficient privileges: Not in reviewers |
1 similar comment
|
@malbarbo: 🔑 Insufficient privileges: Not in reviewers |
|
Done. |
|
@bors: r+ delegate+ |
|
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove [WIP] from this PR's title when it is ready for review. |
|
✌️ @malbarbo can now approve this pull request |
alexcrichton
changed the title
|
@bors: r+ |
|
📌 Commit e54b575 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 7, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
|
@bors r- Failed in rollup #63345 on |
bors
added
S-waiting-on-author
malbarbo
force-pushed
the
musl-libunwind
branch
from
e54b575 to
c9ebd08
Compare
bors
added a commit
that referenced
this pull request
Aug 15, 2019
Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in #61544
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
|
@bors retry rolled up. |
|
⌛ Testing commit 5941acd with merge 76751f45a3eab3a4aea033c58044e2611e056e3d... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
|
@bors retry rolled up. |
bors
added a commit
that referenced
this pull request
Aug 15, 2019
Rollup of 5 pull requests Successful merges: - #63173 (Use libunwind from llvm-project submodule for musl targets) - #63462 (Opaque builtin derive macros) - #63539 (Suggest Rust 2018 on `<expr>.await` with no such field) - #63545 (Feature gate 'yield $expr?' pre-expansion) - #63584 (libcore: more cleanups using `#![feature(associated_type_bounds)]`) Failed merges: r? @ghost
|
⌛ Testing commit 5941acd with merge 1b5bc8ee7c06742731b0684c0c19f642fa129c5d... |
|
I think this failed in #63607 (comment) but I'm not 100% sure. @bors r- meanwhile. |
bors
added
S-waiting-on-author
|
@bors retry |
bors
added
S-waiting-on-bors
|
Seems like this PR wasn't to blame after all... @bors r=alexcrichton |
|
📌 Commit 5941acd has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 16, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
bors
added a commit
that referenced
this pull request
Aug 16, 2019
Rollup of 7 pull requests Successful merges: - #62593 (Group all ABI tests.) - #63173 (Use libunwind from llvm-project submodule for musl targets) - #63535 (Continue refactoring resolve and hygiene) - #63539 (Suggest Rust 2018 on `<expr>.await` with no such field) - #63584 (libcore: more cleanups using `#![feature(associated_type_bounds)]`) - #63612 (Do not suggest `try_into` for base types inside of macro expansions) - #63615 (Fix typo in DoubleEndedIterator::nth_back doc) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid downloading libunwind by using the scheme introduced in #61544