Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify semantics of mem::zeroed #63215

Merged
merged 3 commits into from
Aug 3, 2019
Merged

Clarify semantics of mem::zeroed #63215

merged 3 commits into from
Aug 3, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Aug 2, 2019 •
edited
Loading

Clarifies the semantics of mem::zeroed.

r? @Centril

cc @RalfJung

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2019
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Aug 2, 2019

r? @Centril - cc @RalfJung

@rust-highfive rust-highfive assigned Centril and unassigned dtolnay Aug 2, 2019
hanna-kruppe
hanna-kruppe approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@hanna-kruppe hanna-kruppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this but let's give @Centril a chance to react, too.

@rust-highfive

This comment has been minimized.

Sign in to view
@gnzlbg
Remove trailing whitespace
13b4afe 
I had one job...
RalfJung
RalfJung approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the nit.

src/libcore/mem/mod.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Aug 2, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 2, 2019

📌 Commit 3725e35 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 2, 2019
@Centril
Rollup merge of rust-lang#63215 - gnzlbg:patch-6, r=Centril
4520a39 
Clarify semantics of mem::zeroed

Clarifies the semantics of `mem::zeroed`.

r? @Centril

cc @RalfJung
@Centril Centril mentioned this pull request Aug 2, 2019
Merged
bors added a commit that referenced this pull request Aug 2, 2019
@bors
Auto merge of #63228 - Centril:rollup-x39p5ga, r=Centril
d9bd4b2 
Rollup of 7 pull requests

Successful merges:

 - #63107 (Added support for armv7-unknown-linux-gnueabi/musleabi)
 - #63121 (On `format!()` arg count mismatch provide extra info)
 - #63196 (build_helper: try less confusing method names)
 - #63206 (remove unsupported test case)
 - #63208 (Round generator sizes to a multiple of their alignment)
 - #63212 (Pretty print attributes in `print_arg`)
 - #63215 (Clarify semantics of mem::zeroed)

Failed merges:

r? @ghost
@bors bors merged commit 3725e35 into rust-lang:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanna-kruppe hanna-kruppe hanna-kruppe approved these changes

@Centril Centril Centril approved these changes

@RalfJung RalfJung RalfJung approved these changes

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gnzlbg @rust-highfive @Centril @bors @RalfJung @hanna-kruppe @dtolnay