-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build rustc for the host as well as target in tools #64862
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
3046cbc
to
48d4435
Compare
I think this builds rustc one more time on all builders (this isn't the symlinked one) as shown from the test changes, so I think this would mean we'd slow down all our dist builders? |
Yeah, I think you're right -- I plan to try and allocate some time to figure out why this dependency is necessary, since it seems like it shouldn't be. I personally suspect |
Also to be clear I haven't investigate the linked issue here, and I'm not 100% familiar with |
Sure, yes -- I haven't spent more than a couple hours on this either :) |
BTW, in an attempt to see where this would get a cross-compile, I locally applied the above commit and re-tried a cross-build of 1.38.0 with amd64 as host and armv7 as target, but I'm still unable to complete a cross build, the error is
|
I enabled
This is probably caused by |
I don't seem to have the time to invest in this just now so going to go ahead and close. |
I believe this should fix clippy etc for cross compiled platforms (clippy is currently broken for other reasons it seems, though, so not sure how to test. I don't get the 'crate not found' errors, anyway).
cc #62558
r? @alexcrichton