-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create E0744 error code for unterminated raw string error #66035
Create E0744 error code for unterminated raw string error #66035
Conversation
Some changes occurred in diagnostic error codes |
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
I can't make it fail locally. Anyone has an idea about what's going on? |
r? @estebank |
@@ -518,6 +518,24 @@ undefined number of parameters to a given function (like `printf` in C). The | |||
equivalent in Rust would be to use macros directly. | |||
"##, | |||
|
|||
E0744: r##" | |||
A raw string isn't terminated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A raw string isn't terminated. | |
A raw string isn't correctly terminated because the trailing `#` count doesn't match its leading `#` count. |
@GuillaumeGomez could the error code be in use by a recent commit? Have you tried rebasing against latest master? |
I rebased before making the changes but I can retry. |
7245bb9
to
eec598a
Compare
Rebased so let's see now... (Running tests didn't change anything apparently) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Since failing on the error code index generator. I'll definitely need to check what's going on more deeply because the logs aren't helping. |
☔ The latest upstream changes (presumably #65324) made this pull request unmergeable. Please resolve the merge conflicts. |
The error is actually coming from |
And the problem seems to be fixed in the next pulldown_cmark version so let's wait for #65894 to get merged first... |
r=me after rebase and green ci |
Waiting for #66314 to be merged first then need to update the error code number (E0744 has been taken in the meantime). |
Ping from triage |
For now it's useless considering I'm waiting for another PR to get merged. |
Still blocked on #65894. |
No description provided.