follow the same function order in the trait #66779
Conversation
This removes several warnings in IDE.
|
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
can you elaborate that? |
|
Thanks @bors r+ rollup |
|
📌 Commit 55d7258 has been approved by |
bors
added
S-waiting-on-bors
follow the same function order in the trait With this change, the function order in both traits and implementation matches. And this fix removes several warnings in IDE.
Rollup of 14 pull requests Successful merges: - #66128 (alloc: Add new_zeroed() versions like new_uninit().) - #66661 (Add riscv64gc-unknown-linux-gnu target) - #66663 (Miri: print leak report even without tracing) - #66711 (Add hardware floating point features to aarch64-pc-windows-msvc) - #66713 (introduce a target to build the kernel of the unikernel HermitCore) - #66717 (tidy: Accommodate rustfmt's preferred layout of stability attributes) - #66719 (Store pointer width as u32 on Config) - #66720 (Move ErrorReported to rustc_errors) - #66737 (Error codes cleanup) - #66754 (Various tweaks to diagnostic output) - #66763 (Minor edit for documentation-tests.md that increases clarity) - #66779 (follow the same function order in the trait) - #66786 (Add wildcard test for const_if_match) - #66788 (Allow `Unreachable` terminators through `min_const_fn` checks) Failed merges: r? @ghost
This fixes several warnings in CLion with Rust plugin installed. |
with elabrorate I mean, explain please what kind of warnings the plugin gives you. |
I can't remember the exact warning messages, but it's roughly about "the function order doesn't match the order declared in the traits". |
With this change, the function order in both traits and implementation matches.
And this fix removes several warnings in IDE.