Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make conflicting_repr_hints a deny-by-default c-future-compat lint #68586

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Make conflicting_repr_hints a deny-by-default c-future-compat lint #68586

merged 1 commit into from
Jan 29, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jan 27, 2020 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2020
@Centril Centril mentioned this pull request Jan 28, 2020
Closed
@Centril Centril added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 28, 2020
@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 28, 2020

📌 Commit 979f5b4 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2020
@Centril Centril mentioned this pull request Jan 28, 2020
Merged
@petrochenkov
Copy link
Contributor

r? @pnkfelix

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 29, 2020
@JohnTitor
Rollup merge of rust-lang#68586 - Centril:repr-deny, r=pnkfelix
8f1857a 
Make conflicting_repr_hints a deny-by-default c-future-compat lint

Closes rust-lang#68428.
cc rust-lang#68585.

r? @petrochenkov @pnkfelix
@JohnTitor JohnTitor mentioned this pull request Jan 29, 2020
Merged
bors added a commit that referenced this pull request Jan 29, 2020
@bors
Auto merge of #68635 - JohnTitor:rollup-jsc34ac, r=JohnTitor
eed12bc 
Rollup of 7 pull requests

Successful merges:

 - #67722 (Minor: note how Any is an unsafe trait in SAFETY comments)
 - #68586 (Make conflicting_repr_hints a deny-by-default c-future-compat lint)
 - #68598 (Fix null synthetic_implementors error)
 - #68603 (Changelog: Demonstrate final build-override syntax)
 - #68609 (Set lld flavor for MSVC to link.exe)
 - #68611 (Correct ICE caused by macros generating invalid spans.)
 - #68627 (Document that write_all will not call write if given an empty buffer)

Failed merges:

r? @ghost
@bors bors merged commit 979f5b4 into rust-lang:master Jan 29, 2020
@Centril Centril deleted the repr-deny branch January 29, 2020 17:12
@Centril Centril removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jan 29, 2020
@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 15, 2020
@Mark-Simulacrum
Copy link
Member

Re-adding beta-nomination, AFAICT this didn't get into beta.

error[E0566]: conflicting representation hints

Number of crates regressed: 2

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 15, 2020
Closed
@pnkfelix
Copy link
Member

discussed at T-compiler meeting. Approved for beta backport.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 20, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 21, 2020
Merged
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 21, 2020
bors added a commit that referenced this pull request Feb 24, 2020
@bors
Auto merge of #69360 - Mark-Simulacrum:beta-next, r=Mark-Simulacrum
13e0fbc 
[beta] beta backports

This backports the following PRs:

* Revert "Remove `checked_add` in `Layout::repeat`" #69241
* Do not ICE when encountering `yield` inside `async` block #69175
* Fix MIR typeck soundness holes #69145
* Fix extra subslice lowering #69128
* Correct ICE caused by macros generating invalid spans. #68611
* Make conflicting_repr_hints a deny-by-default c-future-compat lint #68586
@Centril Centril mentioned this pull request Feb 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Conflicting representations" warning became an error
6 participants
@Centril @pnkfelix @bors @petrochenkov @Mark-Simulacrum @rust-highfive