-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade GCC to 8.3.0, glibc to 2.17.0 and crosstool-ng to 1.24.0 for dist-arm-linux and dist-armhf-linux #70414
Conversation
…dist-arm-linux and dist-armhf-linux
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pietroalbini (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for this PR! Could you remove the duplication of the crosstool-ng installation script? Moving a copy of it to |
Done. |
Thanks for the PR! @bors r+ rollup=never |
📌 Commit 55bdb61 has been approved by |
@bors p=1 |
⌛ Testing commit 55bdb61 with merge 4e4a6403cf67462a2633da2a1889b8e0872d0e6e... |
@bors retry (yield) |
☀️ Test successful - checks-azure |
Attempt to fix #69420 in the same manner as #65302 did for armv7l. I have tested that this eliminates the segfault while building a
hello_world
package onarm-unknown-linux-gnueabihf
.I have not been able to test whether the bug exists for
arm-unknown-linux-gnueabi
as well, but I suspect it does, so I upgraded the toolchain for that platform as well.