Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk: arm support - disable tls of jemalloc on rt.mk #7094

Merged
merged 1 commit into from
Jun 13, 2013
Merged

mk: arm support - disable tls of jemalloc on rt.mk #7094

merged 1 commit into from
Jun 13, 2013

Conversation

yichoi
Copy link
Contributor

@yichoi yichoi commented Jun 13, 2013

rt.mk :
in case of arm, add --disable-tls at jemalloc configure
(to solve SEGV)

@yichoi yichoi mentioned this pull request Jun 13, 2013
bors added a commit that referenced this pull request Jun 13, 2013
rt.mk : 
  in case of arm, add --disable-tls at jemalloc configure
  (to solve SEGV)
@bors bors closed this Jun 13, 2013
@bors bors merged commit 00ff170 into rust-lang:incoming Jun 13, 2013
@yichoi yichoi deleted the arm_jemalloc branch June 13, 2013 07:47
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 20, 2021
match_single_binding: Fix invalid suggestion when match scrutinee has side effects

fixes rust-lang#7094

changelog: `match_single_binding`: Fix invalid suggestion when match scrutinee has side effects

---
`Expr::can_have_side_effects` is used to determine the scrutinee has side effects, while this method is a little bit conservative for our use case. But I'd like to use it to avoid reimplementation of the method and too much heuristics. If you think this is problematic, then I'll implement a custom visitor to address it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants