Rollup of 7 pull requests #71230
Merged
Rollup of 7 pull requests #71230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IteratorImpl to avoid exposing default functions outside of the current crate.
Removed unnecessarry empty impls. Moved code to organise it better
An earlier commit (99ed06e) accidentally changed this paragraph from the original, imperative "Provide" to the present tense "Provides". The latter is indeed the standard for Rustdoc comments relating to a function or method, but this snippet is introducing the Default trait in general terms and not talking about any particular function. I believe this change was likely made in error and should be reverted.
…eGomez Add long error explanation for E0657 Added proper error explanation for issue E0657 in the Rust compiler. Part of rust-lang#61137 r? @GuillaumeGomez
Hides default fns inside Fuse impl to avoid exposing it to any crate Fixes rust-lang#70796 @cuviper I've added some default, private traits to do the job for us. If required, I can expose them to a specific visibility if you want to call these functions for rust-lang#70332 r? @cuviper
reword Miri validity errors: undefined -> uninitialized I don't think we say "undefined value" or anything like that anywhere in the docs or so, but we do use the term "uninitialized memory", so I think we should do the same here. Longer-term, I think we should also internally rename "undef" to "uninit". r? @oli-obk
…Simulacrum Add some regression tests Closes rust-lang#24843 Closes rust-lang#28575 Closes rust-lang#54067 Closes rust-lang#66868 Closes rust-lang#67893 Closes rust-lang#68813
Miri error messages: avoid try terminology r? @oli-obk
…ulacrum Dogfood or_patterns in the standard library We can start using `or_patterns` in the standard library as a step toward stabilization. cc rust-lang#54883 @Centril
…vink Fix typo in Default trait docs: Provides -> Provide An earlier commit (99ed06e) accidentally changed this paragraph from the original, imperative `Provide` to the present tense `Provides`. The latter is indeed the standard for Rustdoc comments relating to a function or method, but this snippet is introducing the `Default` trait in general terms and not talking about any particular function. I believe this change was likely made in error and should be reverted.
|
@bors r+ p=7 rollup=never |
|
📌 Commit 65243a8 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost