Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add message for resolution failure because wrong namespace #71419

Merged
merged 2 commits into from
Apr 27, 2020
Merged

add message for resolution failure because wrong namespace #71419

merged 2 commits into from
Apr 27, 2020

Conversation

contrun
Copy link
Contributor

@contrun contrun commented Apr 22, 2020

closes #71406

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020
@contrun contrun mentioned this pull request Apr 22, 2020
Closed
@contrun contrun force-pushed the wrong-namespace-rustc-resolve branch from 7e9fcc9 to bb1eedb Compare April 22, 2020 08:05
@petrochenkov petrochenkov self-assigned this Apr 22, 2020
@estebank
Copy link
Contributor

r? @petrochenkov

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2020
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2020

📌 Commit eb8a703 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 27, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2020
@bors
Auto merge of rust-lang#71600 - Dylan-DPC:rollup-7tvzi9n, r=Dylan-DPC
ef71df1 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#68716 (Stabilize `Span::mixed_site`)
 - rust-lang#71263 (Remove unused abs_path method from rustc_span::source_map::FileLoader)
 - rust-lang#71409 (Point at the return type on `.into()` failure caused by `?`)
 - rust-lang#71419 (add message for resolution failure because wrong namespace)
 - rust-lang#71438 (Tweak some suggestions in `rustc_resolve`)
 - rust-lang#71589 (remove Unique::from for shared pointer types)

Failed merges:

r? @ghost
@bors bors merged commit 94ac0ac into rust-lang:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@estebank estebank estebank left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading error message when ambiguity between a function and module is introduced
5 participants
@contrun @rust-highfive @estebank @petrochenkov @bors