-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unsized_locals to INCOMPLETE_FEATURES list #71435
Add unsized_locals to INCOMPLETE_FEATURES list #71435
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
I'd prefer to add |
6904188
to
5d3b331
Compare
I was added the warning to most of the tests but now I've removed the ones that are |
Cc #71420 Son what is the plan here? As I said before I don't think "incomplete" is an appropriate term for a feature for which we don't have an implementation strategy. If the plan is to have a "sound" subset of unsized locals, IMO it would be better to make |
This doesn't make sense anymore, we are taking this route. |
Turns out there actually is an implementation strategy, I just failed to see it: use (Posting this here in case people stumble upon it without the context of #71416.) |
This is part of what we need to do for #71416
May notice that some tests files have changed because of rustfmt on saving that I forgot to turn off. Still I left the PR in the way it is because I think it doesn't hurt but I can adjust it if bothers the review.
r? @RalfJung @nikomatsakis