Rename "--display-warnings" to "--display-doctest-warnings" #73314

GuillaumeGomez · 2020-06-13T13:01:30Z

Fixes #41574.

cc @ollie27
r? @kinnison

kinnison · 2020-06-14T17:08:13Z

I'm unclear exactly how much of the issue remains unresolved.

GuillaumeGomez · 2020-06-15T18:13:42Z

Me neither actually. Like I said, I don't consider remaining "issues" as issues.

kinnison · 2020-06-16T12:35:20Z

AFAICT that all makes sense. Do we need Cargo on-board with this or is it entirely independent?

GuillaumeGomez · 2020-06-21T09:18:51Z

Let's ping them to be sure. :)

cc @rust-lang/cargo

ehuss · 2020-06-21T16:39:55Z

Seems fine to me, I don't think it will affect cargo at all.

I noticed that it doesn't seem to have an effect for a normal doc build (without --test). In what scenarios would it display a warning?

kinnison · 2020-06-25T07:21:12Z

@GuillaumeGomez Does the user have to invoke rustdoc manually in order to trigger this warning display mechanism?

GuillaumeGomez · 2020-06-25T11:23:19Z

Actually I wonder if the option name is the best... Cargo will have to be updated to take it into account though. The equivalent would be --no-capture. What do you think?

cc @rust-lang/rustdoc @ehuss

ehuss · 2020-06-30T21:30:21Z

From what I can tell, this is different from --nocapture. It is more like --show-output (which is subtly different) plus remove allow(unused). The original name seems fine to me.

I still don't see how this works for normal documentation. The docs added in this PR imply that rustdoc foo.rs --display-warnings should do something, but I don't see how.

I'm also not sure in what way cargo would need to know about this. Generally we don't add flags to cargo doc unless there is a prevailing need. For niche flags like this, typically RUSTDOCFLAGS should be good enough (or cargo rustdoc -- --show-output).

GuillaumeGomez · 2020-07-17T13:01:56Z

Then is there anything else to be done here or can we move forward?

jyn514 · 2020-07-30T03:06:58Z

Looks good to me :)

GuillaumeGomez · 2020-07-30T09:07:52Z

ping @Manishearth @ollie27

Mark-Simulacrum · 2020-07-30T12:10:28Z

Could someone elaborate on what issues remain unresolved (whether we call them issues or not)? I so far have not been able to find any comment explaining that, and I feel mildly uncomfortable stabilizing something that multiple people agree has some problem without actually saying what that problem is.

I also don't see any tests for this in-tree, and I feel like that would be good to add before stabilization to make sure it keeps working as we intend.

It also looks like the option currently does not color the warnings, but I suppose that's #74293, right?

GuillaumeGomez · 2020-07-30T12:20:09Z

I don't know if it's an issue considering that I treat separately. The purpose is different: one provides information and the other makes it look more beautiful. But we can wait on #74293 if people want?

Manishearth · 2020-07-30T15:32:12Z

Can we call this --display-doctest-warnings? I saw the name --display-warnings and was immediately confused.

GuillaumeGomez · 2020-07-30T15:33:54Z

@Manishearth It sounds much better, indeed!

ollie27 · 2020-08-03T23:22:11Z

To reiterate the concerns from #41574 (comment) and #41574 (comment). --display-warnings seems to do 3 fairly unrelated things:

It enables all lints when building docs or collecting doctests.

The reason most lints are disabled in rustdoc is because they simply don't work. Adding a command line option to enable them again doesn't seem useful.
It displays the output of rustc when compiling doctests even if they pass.

Passing --test-args --nocapture will already do this. I don't know why we would need another option to do the same thing.
It stops the automatic adding of #![allow(unused)] to doctests.

You can already do this be adding a crate level attribute like #![doc(test(attr(warn(warnings))))]. Although I'm tempted to say we should stop adding #![allow(unused)] in general because we don't display warnings if the doctest passes anyway and if it fails displaying these lints can be useful.

So overall, what actually are the use cases for --display-warnings?

jyn514 · 2020-08-04T00:09:16Z

Can we document everything you just said? I didn't know -- --no-capture would show the warnings, that was the main reason I wanted this.

ollie27 · 2020-08-04T01:08:26Z

Looking at this a bit closer, --test-args --nocapture will interleave the outputs from many tests unless you also pass --test-args --test-threads=1 so it isn't really the same as --display-warnings which doesn't have that issue.

--display-warnings actually enables --show-output. We could instead just allow --test-args --show-output to work (currently it's ignored because --display-warnings takes precedence) so we wouldn't need a dedicated --display-warnings.

Dylan-DPC-zz · 2020-08-18T23:58:53Z

r? @jyn514

jyn514 · 2020-08-19T01:00:01Z

Going over ollie's comments again:

It enables all lints when building docs or collecting doctests. The reason most lints are disabled in rustdoc is because they simply don't work.

Hmm .. this is definitely true for when rustdoc checks the items (especially after #73566), but is it true for doctests? One of the main reasons I wanted this feature was to see warnings in doctests.

If warnings are already on by default in doctests that sounds fine to me. I don't think we need a dedicated flag for hiding warnings while checking items.

It displays the output of rustc when compiling doctests even if they pass. Passing --test-args --nocapture will already do this. I don't know why we would need another option to do the same thing.
--display-warnings actually enables --show-output. We could instead just allow --test-args --show-output to work (currently it's ignored because --display-warnings takes precedence) so we wouldn't need a dedicated --display-warnings.

--show-output sounds good to me 👍

It stops the automatic adding of #![allow(unused)] to doctests. You can already do this be adding a crate level attribute like #![doc(test(attr(warn(warnings))))]

This seems really hard to discover. There's a brief mention of doc(test(attr(...))) in https://doc.rust-lang.org/rustdoc/the-doc-attribute.html#testattr, but no mention of warn(warnings). In particular, it's not clear at all that warnings are allowed in doc-tests by default.

Maybe this is a documentation issue? But I'd be very unhappy with #![doc(test(attr(warn(warnings))))] as is, and even if we documented it it seems over-complicated.

GuillaumeGomez · 2020-08-19T12:23:51Z

Renamed the option and added a test (realized we didn't have one yet).

jyn514 · 2020-08-19T13:14:19Z

Renamed the option

Sorry, I wasn't clear: I was referring to the --show-output option to libtest:

$ cargo test -q --lib -- -h | grep show-output
        --show-output   Show captured stdout of successful tests

Which is a behavior change from what --display-warnings does currently I think. The goal is for cargo test --doc -- --show-output to pass on that flag to the test suite.

GuillaumeGomez · 2020-08-19T17:59:51Z

It's the case already, no? Or did I miss something?

jyn514 · 2020-08-22T02:04:41Z

Recapping one last time because it seems I misunderstood the first time:

This stops rustdoc from adding allow(warnings) to doctests,
This passes --display-output on to the test suite.

I think having those both in one option is helpful.

@rfcbot fcp merge

jyn514 · 2021-09-09T19:45:48Z

@bors r+

GuillaumeGomez · 2021-09-14T08:50:22Z

Fixed conflict.

@bors: r=jyn514

bors · 2021-09-14T08:50:23Z

📌 Commit b531a7f has been approved by jyn514

bors · 2021-09-14T14:20:50Z

⌛ Testing commit b531a7f with merge 18c85fa589bde20d19f5a94f97af428ef783cf86...

rust-log-analyzer · 2021-09-14T14:57:54Z

The job dist-i686-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling unwind v0.0.0 (D:\a\rust\rust\library\unwind)
   Compiling profiler_builtins v0.0.0 (D:\a\rust\rust\library\profiler_builtins)
[RUSTC-TIMING] build_script_build test:false 0.347
[RUSTC-TIMING] build_script_build test:false 0.395
error: linking with `link.exe` failed: exit code: 1104
  |
  = note: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x86\\link.exe" "/NOLOGO" "/LARGEADDRESSAWARE" "/SAFESEH" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.0.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.1.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.10.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.11.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.12.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.13.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.14.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.15.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.16.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.17.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.18.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.19.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.2.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.20.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.21.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.22.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.23.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.24.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.25.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.26.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.27.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.28.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.29.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.3.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.30.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.31.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.32.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.33.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.34.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.35.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.36.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.37.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.38.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.39.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.4.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.40.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.41.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.42.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.43.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.44.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.45.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.46.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.47.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.48.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.49.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.5.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.50.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.51.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.52.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.53.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.54.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.55.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.56.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.57.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.58.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.59.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.6.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.60.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.61.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.62.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.63.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.64.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.65.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.66.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.67.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.68.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.69.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.7.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.70.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.71.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.72.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.73.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.74.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.75.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.8.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.build_script_build.2fb4f6f4-cgu.9.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.3ar2vb4p8ez9ju52.rcgu.o" "/LIBPATH:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\deps" "/LIBPATH:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\deps\\libcc-c30122eb73a2e2a5.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libstd-81cb19e6a508a382.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libpanic_unwind-d68169d5fd63206c.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libstd_detect-f7aff418b211f3b4.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\librustc_demangle-bde83a8e075cbb6d.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libhashbrown-d018f29c6b54b3e3.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\librustc_std_workspace_alloc-57a11699c9cdcc43.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libunwind-8ea0c0e26bfbf063.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libcfg_if-423bcb240d49abd0.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\liblibc-2e26fae3a666b111.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\liballoc-dd6f76dfeed99195.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\librustc_std_workspace_core-31972101b01c6747.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libcore-4d870864fbc17473.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libcompiler_builtins-771055d60d4c83bb.rlib" "advapi32.lib" "ole32.lib" "oleaut32.lib" "kernel32.lib" "ws2_32.lib" "advapi32.lib" "userenv.lib" "kernel32.lib" "libcmt.lib" "/NXCOMPAT" "/LIBPATH:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\i686-pc-windows-msvc\\lib" "/OUT:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2-std\\release\\build\\compiler_builtins-3ad280178e43f3ea\\build_script_build-3ad280178e43f3ea.exe" "/OPT:REF,NOICF" "/DEBUG" "/NATVIS:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\etc\\intrinsic.natvis" "/NATVIS:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\etc\\libcore.natvis" "/NATVIS:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0\\lib\\rustlib\\etc\\libstd.natvis"
  = note: LINK : fatal error LNK1104: cannot open file 'D:\a\rust\rust\build\i686-pc-windows-msvc\stage2-std\release\build\compiler_builtins-3ad280178e43f3ea\build_script_build-3ad280178e43f3ea.exe'
          

[RUSTC-TIMING] build_script_build test:false 0.665
error: could not compile `compiler_builtins` due to previous error

bors · 2021-09-14T14:58:29Z

💔 Test failed - checks-actions

GuillaumeGomez · 2021-09-14T15:01:54Z

@bors: retry

bors · 2021-09-14T16:05:47Z

⌛ Testing commit b531a7f with merge c3c0f80...

bors · 2021-09-14T19:18:23Z

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing c3c0f80 to master...

rust-timer · 2021-09-14T20:58:08Z

Finished benchmarking commit (c3c0f80): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

…eGomez Remove `--display-doctest-warnings` `--display-doctest-warnings` can be replicated in full with other existing features, there's no need to have a separate option for it. This removes the option and documents the combination of other features to replicate it. This also fixes a bug where `--test-args=--show-output` had no effect. cc `@ollie27,` rust-lang#73314 (comment) Fixes rust-lang#41574 r? `@GuillaumeGomez`

rust-highfive assigned kinnison Jun 13, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2020

ollie27 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 24, 2020

rust-highfive assigned jyn514 and unassigned kinnison Aug 18, 2020

GuillaumeGomez force-pushed the display-warnings branch from 7dbb8d9 to 7590adc Compare August 19, 2020 12:21

GuillaumeGomez mentioned this pull request Sep 9, 2021

Remove attribute for display_warnings #88792

Closed

GuillaumeGomez added 2 commits September 14, 2021 10:49

Rename --display-warnings to --display-doctest-warnings

3a8fcff

Add test for --display-doctest-warnings option

b531a7f

GuillaumeGomez force-pushed the display-warnings branch from 872d82f to b531a7f Compare September 14, 2021 08:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 14, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 14, 2021

bors merged commit c3c0f80 into rust-lang:master Sep 14, 2021

rustbot added this to the 1.57.0 milestone Sep 14, 2021

GuillaumeGomez deleted the display-warnings branch September 14, 2021 19:29

This was referenced Nov 26, 2021

Feature request: cargo check for documentation rust-lang/cargo#10025

Open

Remove --display-doctest-warnings #91259

Merged

dylni mentioned this pull request Nov 29, 2021

intra-doc links: Links with unexpected characters are silently ignored #77199

Closed

jyn514 mentioned this pull request Jul 6, 2022

sess: stabilize -Zterminal-width as --diagnostic-width #95635

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename "--display-warnings" to "--display-doctest-warnings" #73314

Rename "--display-warnings" to "--display-doctest-warnings" #73314

GuillaumeGomez commented Jun 13, 2020 •

edited

Loading

kinnison commented Jun 14, 2020

GuillaumeGomez commented Jun 15, 2020

kinnison commented Jun 16, 2020

GuillaumeGomez commented Jun 21, 2020

ehuss commented Jun 21, 2020

kinnison commented Jun 25, 2020

GuillaumeGomez commented Jun 25, 2020

ehuss commented Jun 30, 2020

GuillaumeGomez commented Jul 17, 2020

jyn514 commented Jul 30, 2020

GuillaumeGomez commented Jul 30, 2020

Mark-Simulacrum commented Jul 30, 2020

GuillaumeGomez commented Jul 30, 2020

Manishearth commented Jul 30, 2020

GuillaumeGomez commented Jul 30, 2020

ollie27 commented Aug 3, 2020

jyn514 commented Aug 4, 2020

ollie27 commented Aug 4, 2020

Dylan-DPC-zz commented Aug 18, 2020

jyn514 commented Aug 19, 2020

GuillaumeGomez commented Aug 19, 2020

jyn514 commented Aug 19, 2020 •

edited

Loading

GuillaumeGomez commented Aug 19, 2020

jyn514 commented Aug 22, 2020

jyn514 commented Sep 9, 2021

GuillaumeGomez commented Sep 14, 2021

bors commented Sep 14, 2021

bors commented Sep 14, 2021

rust-log-analyzer commented Sep 14, 2021

bors commented Sep 14, 2021

GuillaumeGomez commented Sep 14, 2021

bors commented Sep 14, 2021

bors commented Sep 14, 2021

rust-timer commented Sep 14, 2021

Rename "--display-warnings" to "--display-doctest-warnings" #73314

Rename "--display-warnings" to "--display-doctest-warnings" #73314

Conversation

GuillaumeGomez commented Jun 13, 2020 • edited Loading

kinnison commented Jun 14, 2020

GuillaumeGomez commented Jun 15, 2020

kinnison commented Jun 16, 2020

GuillaumeGomez commented Jun 21, 2020

ehuss commented Jun 21, 2020

kinnison commented Jun 25, 2020

GuillaumeGomez commented Jun 25, 2020

ehuss commented Jun 30, 2020

GuillaumeGomez commented Jul 17, 2020

jyn514 commented Jul 30, 2020

GuillaumeGomez commented Jul 30, 2020

Mark-Simulacrum commented Jul 30, 2020

GuillaumeGomez commented Jul 30, 2020

Manishearth commented Jul 30, 2020

GuillaumeGomez commented Jul 30, 2020

ollie27 commented Aug 3, 2020

jyn514 commented Aug 4, 2020

ollie27 commented Aug 4, 2020

Dylan-DPC-zz commented Aug 18, 2020

jyn514 commented Aug 19, 2020

GuillaumeGomez commented Aug 19, 2020

jyn514 commented Aug 19, 2020 • edited Loading

GuillaumeGomez commented Aug 19, 2020

jyn514 commented Aug 22, 2020

jyn514 commented Sep 9, 2021

GuillaumeGomez commented Sep 14, 2021

bors commented Sep 14, 2021

bors commented Sep 14, 2021

rust-log-analyzer commented Sep 14, 2021

bors commented Sep 14, 2021

GuillaumeGomez commented Sep 14, 2021

bors commented Sep 14, 2021

bors commented Sep 14, 2021

rust-timer commented Sep 14, 2021

GuillaumeGomez commented Jun 13, 2020 •

edited

Loading

jyn514 commented Aug 19, 2020 •

edited

Loading