Add rust specific features to print target features #73346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`crt-static` is a rust specific target feature that's absent from llvm feature table, adding it there.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
cuviper
reviewed
Jun 15, 2020
src/rustllvm/PassWrapper.cpp
Outdated
| @@ -425,6 +425,9 @@ extern "C" void LLVMRustPrintTargetFeatures(LLVMTargetMachineRef TM) { | |||
| for (auto &Feature : FeatTable) | |||
| printf(" %-*s - %s.\n", MaxFeatLen, Feature.Key, Feature.Desc); | |||
| printf("\n"); | |||
| // Rust specific target features | |||
There was a problem hiding this comment.
If we're going to have this block separated by an empty line, perhaps it should print a new header too, like "Rust-specific features:".
There was a problem hiding this comment.
thanks, makes sense. done
cuviper
reviewed
Jun 17, 2020
src/rustllvm/PassWrapper.cpp
Outdated
| @@ -424,6 +424,12 @@ extern "C" void LLVMRustPrintTargetFeatures(LLVMTargetMachineRef TM) { | |||
| printf("Available features for this target:\n"); | |||
| for (auto &Feature : FeatTable) | |||
| printf(" %-*s - %s.\n", MaxFeatLen, Feature.Key, Feature.Desc); | |||
| printf("Rust-specific features:\n"); | |||
There was a problem hiding this comment.
Sorry to keep nit-picking, but I think we should still have a blank line between the sections too.
Suggested change
| printf("Rust-specific features:\n"); | |
| printf("\nRust-specific features:\n"); |
Separate target features from rust ones with a blank line Co-authored-by: Josh Stone <[email protected]>
|
@bors r+ rollup |
|
📌 Commit caffb28 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 18, 2020
Add rust specific features to print target features Fixes rust-lang#71583 `crt-static` is a rust specific target feature that's absent from llvm feature table, adding it there so that it shows under `rustc --print target-features`. Probably the most native implementation I could think of, would love to get feedback.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 18, 2020
Add rust specific features to print target features Fixes rust-lang#71583 `crt-static` is a rust specific target feature that's absent from llvm feature table, adding it there so that it shows under `rustc --print target-features`. Probably the most native implementation I could think of, would love to get feedback.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 19, 2020
Add rust specific features to print target features Fixes rust-lang#71583 `crt-static` is a rust specific target feature that's absent from llvm feature table, adding it there so that it shows under `rustc --print target-features`. Probably the most native implementation I could think of, would love to get feedback.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#70740 (Enabling static-pie for musl) - rust-lang#72331 (Report error when casting an C-like enum implementing Drop) - rust-lang#72486 (Fix asinh of negative values) - rust-lang#72497 (tag/niche terminology cleanup) - rust-lang#72999 (Create self-contained directory and move there some of external binaries/libs) - rust-lang#73130 (Remove const prop for indirects) - rust-lang#73142 (Ensure std benchmarks get tested.) - rust-lang#73305 (Disallow loading crates with non-ascii identifier name.) - rust-lang#73346 (Add rust specific features to print target features) - rust-lang#73362 (Test that bounds checks are elided when slice len is checked up-front) - rust-lang#73459 (Reduce pointer casts in Box::into_boxed_slice) - rust-lang#73464 (Document format correction) - rust-lang#73479 (Minor tweaks to liballoc) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71583
crt-staticis a rust specific target feature that's absent from llvm feature table, adding it there so that it shows underrustc --print target-features.Probably the most native implementation I could think of, would love to get feedback.