Validate built-in attribute placement #73461

calebzulawski · 2020-06-18T00:00:14Z

Closes #54584, closes #47725, closes #54044.

I've changed silently ignoring some incorrectly placed attributes to errors. I'm not sure what the policy is since this can theoretically break code (should they be warnings instead? does it warrant a crater run?).

rust-highfive · 2020-06-18T00:00:17Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

src/librustc_passes/check_attr.rs

matthewjasper · 2020-06-20T11:45:50Z

src/librustc_typeck/collect.rs

@@ -2430,7 +2430,7 @@ fn codegen_fn_attrs(tcx: TyCtxt<'_>, id: DefId) -> CodegenFnAttrs {
        } else if attr.check_name(sym::thread_local) {
            codegen_fn_attrs.flags |= CodegenFnAttrFlags::THREAD_LOCAL;
        } else if attr.check_name(sym::track_caller) {
-            if tcx.is_closure(id) || tcx.fn_sig(id).abi() != abi::Abi::Rust {
+            if !tcx.is_closure(id) && tcx.fn_sig(id).abi() != abi::Abi::Rust {


Could these have comments stating that we error when using target feature on a closure in check_attr?

Could this be tcx.fn_sig(id).abi() != abi::Abi::Rust && tcx.fn_sig(id).abi() != abi::Abi::RustCall instead? That would allow #[track_caller] on explicit extern "rust-call" fn.

Does #[track_caller] work with the rust-call ABI? I feel like that change isn't in the scope of this PR

matthewjasper · 2020-06-20T11:48:29Z

I think changes like this in the past have sometimes needed to be warnings because existing code has attributes in incorrect places.
@bors try for a crate run

bors · 2020-06-20T11:48:41Z

⌛ Trying commit 950b376bee6def9c76a98c46e0e3c1c389e8cf09 with merge a8b07dfbca1215bb01afe7f37ca9431b5b2d1ea2...

bors · 2020-06-20T14:43:52Z

☀️ Try build successful - checks-azure
Build commit: a8b07dfbca1215bb01afe7f37ca9431b5b2d1ea2 (a8b07dfbca1215bb01afe7f37ca9431b5b2d1ea2)

matthewjasper · 2020-06-20T15:38:28Z

@craterbot check

craterbot · 2020-06-20T15:38:32Z

👌 Experiment pr-73461 created and queued.
🤖 Automatically detected try build a8b07dfbca1215bb01afe7f37ca9431b5b2d1ea2
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2020-06-22T03:25:08Z

🚧 Experiment pr-73461 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2020-06-24T04:15:58Z

🚨 Experiment pr-73461 has encountered an error: command Command { std: "/workspace/cargo-home/bin/rustup-toolchain-install-master" "033013cab3a861224fd55f494c8be1cb0349eb49" "-c" "cargo", kill_on_drop: false } failed
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2020-06-24T12:34:38Z

@craterbot abort

craterbot · 2020-06-24T12:34:52Z

🗑️ Experiment pr-73461 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2020-06-24T12:35:07Z

@craterbot check

craterbot · 2020-06-24T12:35:16Z

👌 Experiment pr-73461 created and queued.
🤖 Automatically detected try build a8b07dfbca1215bb01afe7f37ca9431b5b2d1ea2
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2020-06-24T12:35:24Z

🚧 Experiment pr-73461 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2020-06-24T12:35:35Z

🚨 Experiment pr-73461 has encountered an error: No such file or directory (os error 2)
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2020-06-26T10:56:05Z

@craterbot abourt

craterbot · 2020-06-26T10:56:07Z

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2020-06-26T10:56:16Z

Woops.

@craterbot abort

craterbot · 2020-06-26T10:56:17Z

🗑️ Experiment pr-73461 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

bors · 2020-09-08T00:21:04Z

⌛ Testing commit 8f69266 with merge ff90b37403daefd136f2a2af65812fa2bcfcf24e...

bors · 2020-09-08T00:58:39Z

💔 Test failed - checks-actions

src/test/ui/issues/issue-2214.rs

matthewjasper · 2020-09-12T19:41:55Z

@bors r+

bors · 2020-09-12T19:41:56Z

📌 Commit 82cb379 has been approved by matthewjasper

bors · 2020-09-12T20:56:45Z

⌛ Testing commit 82cb379 with merge 344a1e68bd0107936be904211b2b9dfd27c8f8c2...

bors · 2020-09-12T21:33:31Z

💔 Test failed - checks-actions

ehuss · 2020-09-12T21:59:40Z

@bors retry
network error

warning: spurious network error (2 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/strsim/0.7.0/download`, got 502
warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/strsim/0.7.0/download`, got 502
error: failed to download from `https://crates.io/api/v1/crates/strsim/0.7.0/download`

Caused by:
  failed to get 200 response from `https://crates.io/api/v1/crates/strsim/0.7.0/download`, got 502
thread 'main' panicked at 'tests failed for https://github.com/XAMPPRocky/tokei', src/tools/cargotest/main.rs:72:9

bors · 2020-09-12T22:04:43Z

⌛ Testing commit 82cb379 with merge dbb73f8...

bors · 2020-09-12T23:47:55Z

☀️ Test successful - checks-actions, checks-azure
Approved by: matthewjasper
Pushing dbb73f8 to master...

Clean up some of the pkgsrc Makefile, there's still lots in here that should just be deleted though. Switch SunOS to the illumos bootstrap by default. Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.][77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

Pkgsrc changes: * Compensate for files being moved around upstream. * Introduce optional, on-by-default semi-static building of cargo, using the internal curl and openssl sources. This reduces the dynamic dependencies of cargo and therefore the rust package itself. Ref. options.mk. * The 1.47.0 bootstrap kits have been re-built with the above option turned on, so no longer depends on curl or openssl from pkgsrc and/or from earlier OS or pkgsrc versions. This should hopefully fix installation of rust with non-default PREFIX, ref. PR#54453. Upstream changes: Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.] [77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

rust-highfive assigned matthewjasper Jun 18, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2020

tesuji reviewed Jun 18, 2020

View reviewed changes

src/librustc_passes/check_attr.rs Outdated Show resolved Hide resolved

matthewjasper reviewed Jun 20, 2020

View reviewed changes

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2020

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 24, 2020

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2020

craterbot removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 26, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 8, 2020

tesuji reviewed Sep 8, 2020

View reviewed changes

src/test/ui/issues/issue-2214.rs Outdated Show resolved Hide resolved

Fix broken test on MSVC

82cb379

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2020

bors merged commit dbb73f8 into rust-lang:master Sep 12, 2020

ehuss mentioned this pull request Sep 15, 2020

link_section attribute misleadingly allowed on modules and impls #65128

Open

ehuss mentioned this pull request Oct 30, 2020

Add "Attributes on X" for various places attributes are allowed rust-lang/reference#355

Open

6 tasks

ehuss mentioned this pull request Dec 31, 2020

Compilation succeeds even if there is #[inline] in the structure field. #80564

Closed

ehuss mentioned this pull request Jan 25, 2021

#![inline(never)] vs #[inline(never)] #69365

Closed

Enselic mentioned this pull request Jul 23, 2023

Warn when using link_name in exported items ? #55313

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate built-in attribute placement #73461

Validate built-in attribute placement #73461

calebzulawski commented Jun 18, 2020

rust-highfive commented Jun 18, 2020

matthewjasper Jun 20, 2020

bjorn3 Jul 7, 2020

calebzulawski Jul 11, 2020

matthewjasper commented Jun 20, 2020

bors commented Jun 20, 2020

bors commented Jun 20, 2020

matthewjasper commented Jun 20, 2020

craterbot commented Jun 20, 2020

craterbot commented Jun 22, 2020

craterbot commented Jun 24, 2020

pietroalbini commented Jun 24, 2020

craterbot commented Jun 24, 2020

pietroalbini commented Jun 24, 2020

craterbot commented Jun 24, 2020

craterbot commented Jun 24, 2020

craterbot commented Jun 24, 2020

pietroalbini commented Jun 26, 2020

craterbot commented Jun 26, 2020

pietroalbini commented Jun 26, 2020

craterbot commented Jun 26, 2020

bors commented Sep 8, 2020

bors commented Sep 8, 2020

matthewjasper commented Sep 12, 2020

bors commented Sep 12, 2020

bors commented Sep 12, 2020

bors commented Sep 12, 2020

ehuss commented Sep 12, 2020

bors commented Sep 12, 2020

bors commented Sep 12, 2020

Validate built-in attribute placement #73461

Validate built-in attribute placement #73461

Conversation

calebzulawski commented Jun 18, 2020

rust-highfive commented Jun 18, 2020

matthewjasper Jun 20, 2020

Choose a reason for hiding this comment

bjorn3 Jul 7, 2020

Choose a reason for hiding this comment

calebzulawski Jul 11, 2020

Choose a reason for hiding this comment

matthewjasper commented Jun 20, 2020

bors commented Jun 20, 2020

bors commented Jun 20, 2020

matthewjasper commented Jun 20, 2020

craterbot commented Jun 20, 2020

craterbot commented Jun 22, 2020

craterbot commented Jun 24, 2020

pietroalbini commented Jun 24, 2020

craterbot commented Jun 24, 2020

pietroalbini commented Jun 24, 2020

craterbot commented Jun 24, 2020

craterbot commented Jun 24, 2020

craterbot commented Jun 24, 2020

pietroalbini commented Jun 26, 2020

craterbot commented Jun 26, 2020

pietroalbini commented Jun 26, 2020

craterbot commented Jun 26, 2020

bors commented Sep 8, 2020

bors commented Sep 8, 2020

matthewjasper commented Sep 12, 2020

bors commented Sep 12, 2020

bors commented Sep 12, 2020

bors commented Sep 12, 2020

ehuss commented Sep 12, 2020

bors commented Sep 12, 2020

bors commented Sep 12, 2020