-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ArrayVec
in SparseBitSet
.
#74310
Use ArrayVec
in SparseBitSet
.
#74310
Conversation
Instead of `SmallVec`, because the maximum size is known.
I'm not sure if this will have a performance impact. It's conceivable, given that @bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit c492ca4 with merge 5f73a0df765ce2b9e0b5c8be0815be62eaf83df0... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after perf results
☀️ Try build successful - checks-actions, checks-azure |
Queued 5f73a0df765ce2b9e0b5c8be0815be62eaf83df0 with parent 9d09331, future comparison URL. |
Finished benchmarking try commit (5f73a0df765ce2b9e0b5c8be0815be62eaf83df0): comparison url. |
It's a small but clear win, which is nice given that it also makes the code slightly nicer. @bors r=eddyb |
📌 Commit c492ca4 has been approved by |
…itSet, r=eddyb Use `ArrayVec` in `SparseBitSet`. Instead of `SmallVec`, because the maximum size is known. r? @eddyb
…arth Rollup of 15 pull requests Successful merges: - rust-lang#71237 (Add Ayu theme to rustdoc) - rust-lang#73720 (Clean up E0704 error explanation) - rust-lang#73866 (Obviate #[allow(improper_ctypes_definitions)]) - rust-lang#73965 (typeck: check for infer before type impls trait) - rust-lang#73986 (add (unchecked) indexing methods to raw (and NonNull) slices) - rust-lang#74173 (Detect tuple struct incorrectly used as struct pat) - rust-lang#74220 (Refactor Windows `parse_prefix`) - rust-lang#74227 (Remove an unwrap in layout computation) - rust-lang#74239 (Update llvm-project to latest origin/rustc/10.0-2020-05-05 commit ) - rust-lang#74257 (don't mark linux kernel module targets as a unix environment) - rust-lang#74270 (typeck: report placeholder type error w/out span) - rust-lang#74296 (Clarify the description for rfind) - rust-lang#74310 (Use `ArrayVec` in `SparseBitSet`.) - rust-lang#74316 (Remove unnecessary type hints from Wake internals) - rust-lang#74324 (Update Clippy) Failed merges: r? @ghost
Instead of
SmallVec
, because the maximum size is known.r? @eddyb