Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc theme logo display #74361

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Improve doc theme logo display #74361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/librustdoc/html/static/themes/ayu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ pre {
background-color: #14191f;
}

.logo-container > img {
filter: drop-shadow(0 0 5px #fff);
Copy link
Contributor

@tesuji tesuji Jul 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have license agreement from @UtherII ? (Is he/she the same person here: https://www.reddit.com/r/rust/comments/hrfi8k/ayu_theme_is_now_available_on_nightly_rustdoc/fy4dzum/ ?).
The POC doesn't have any license files: https://github.com/UtherII/poc_rustdoc .

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Jul 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am. Do you want me to add a comment? It seems a bit too much for just a line of CSS but I can add it... Also, they posted it in a reddit channel, I tested it. So not sure what are the rules in this case too...

Copy link
Contributor

@tesuji tesuji Jul 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a lawyer too. I'm just afraid legal issues when UtherII doesn't explicitly grant us the permissions to copy the code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to be a bit of long stretch considering the code was provided in an open discussion but if someone knows about it...

Copy link

@UtherII UtherII Jul 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. You can use it.
I will put a license on my POC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Still very interested in what you'll come up with, with your own POC. :)

}

/* Improve the scrollbar display on firefox */
* {
scrollbar-color: #5c6773 transparent;
Expand Down
4 changes: 4 additions & 0 deletions src/librustdoc/html/static/themes/dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ pre {
background-color: #505050;
}

.logo-container > img {
filter: drop-shadow(0 0 5px #fff);
}

/* Improve the scrollbar display on firefox */
* {
scrollbar-color: rgb(64, 65, 67) #717171;
Expand Down
4 changes: 4 additions & 0 deletions src/librustdoc/html/static/themes/light.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ pre {
scrollbar-color: rgba(36, 37, 39, 0.6) #d9d9d9;
}

.logo-container > img {
filter: drop-shadow(0 0 5px #aaa);
}

/* Improve the scrollbar display on webkit-based browsers */
::-webkit-scrollbar-track {
background-color: #ecebeb;
Expand Down