Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump yanked crates in Cargo.lock #75523

Closed
wants to merge 2 commits into from
Closed

Bump yanked crates in Cargo.lock #75523

wants to merge 2 commits into from

Conversation

workingjubilee
Copy link
Member

While browsing the Cargo.lock, I noticed 1.4.0 was yanked. Apparently there was a (fixed) UB issue. So, bump.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2020
@tesuji
Copy link
Contributor

tesuji commented Aug 14, 2020

Could you also bump quote (yanked) ?

@workingjubilee workingjubilee changed the title Bump smallvec 1.4.0 (yanked) -> 1.4.2 Bump yanked crates in Cargo.lock Aug 14, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Aug 14, 2020

📌 Commit 4c5bdf177a241bb0462e2c3b5e4c45a192d700b4 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2020
@workingjubilee workingjubilee mentioned this pull request Aug 14, 2020
Closed
@workingjubilee
Copy link
Member Author

Actually, let's try #75544 first?

@workingjubilee
Copy link
Member Author

oh, nope. :P

@bors
Copy link
Contributor

bors commented Aug 15, 2020

☔ The latest upstream changes (presumably #73851) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 18, 2020

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Aug 18, 2020

📌 Commit a33ee25 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2020
@Mark-Simulacrum
Copy link
Member

@bors r-

Let's actually not land this, I'd prefer to have just one big-ish Cargo.lock update going.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2020
@workingjubilee workingjubilee deleted the update-yanks branch October 4, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@workingjubilee @rust-highfive @tesuji @Mark-Simulacrum @bors @jyn514