-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing update #76210
Tracing update #76210
Conversation
fe6ea43
to
77d4f94
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 77d4f94 with merge f675271e5c4ae4c4919a22775104a2ead9ff53d8... |
👋 Unfortunately, But, you're still getting some minor fixes etc, so it's probably good to update regardless. |
☀️ Try build successful - checks-actions, checks-azure |
Queued f675271e5c4ae4c4919a22775104a2ead9ff53d8 with parent 58d5ce4, future comparison URL. |
FWIW i would not really expect any significant performance difference from these updates, since the macro change isn't included. |
Finished benchmarking try commit (f675271e5c4ae4c4919a22775104a2ead9ff53d8): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Maybe a tiny win (~0.1%). r? @oli-obk |
@bors r+ |
📌 Commit 77d4f94 has been approved by |
⌛ Testing commit 77d4f94 with merge faa5291f1e7b25ba498873e1ff37c0688edcd4db... |
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions, checks-azure |
This does not bring the more significant changes that are coming down the pipeline, but since I've already prepared the PR leaving it up :)
See #76210 (comment):