Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing update #76210

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Tracing update #76210

merged 1 commit into from
Sep 8, 2020

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Sep 1, 2020

This does not bring the more significant changes that are coming down the pipeline, but since I've already prepared the PR leaving it up :)

See #76210 (comment):

Unfortunately, tracing 0.1.20 — which contained the change to reduce the amount of code generated by the tracing macros — had to be yanked, as it broke previously-compiling code for some downstream crates. I've not yet had the chance to fix this and release a new patch. So, in order to benefit from the changes to reduce generated code, you'll need to wait until there's a new version of tracing as well as tracing-attributes and tracing-core.

@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Sep 1, 2020

⌛ Trying commit 77d4f94 with merge f675271e5c4ae4c4919a22775104a2ead9ff53d8...

@hawkw
Copy link
Contributor

hawkw commented Sep 1, 2020

👋 Unfortunately, tracing 0.1.20 — which contained the change to reduce the amount of code generated by the tracing macros — had to be yanked, as it broke previously-compiling code for some downstream crates. I've not yet had the chance to fix this and release a new patch. So, in order to benefit from the changes to reduce generated code, you'll need to wait until there's a new version of tracing as well as tracing-attributes and tracing-core.

But, you're still getting some minor fixes etc, so it's probably good to update regardless.

@bors
Copy link
Contributor

bors commented Sep 1, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: f675271e5c4ae4c4919a22775104a2ead9ff53d8 (f675271e5c4ae4c4919a22775104a2ead9ff53d8)

@rust-timer
Copy link
Collaborator

Queued f675271e5c4ae4c4919a22775104a2ead9ff53d8 with parent 58d5ce4, future comparison URL.

@hawkw
Copy link
Contributor

hawkw commented Sep 1, 2020

FWIW i would not really expect any significant performance difference from these updates, since the macro change isn't included.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (f675271e5c4ae4c4919a22775104a2ead9ff53d8): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@Mark-Simulacrum
Copy link
Member Author

Maybe a tiny win (~0.1%). r? @oli-obk

@LeSeulArtichaut LeSeulArtichaut added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Sep 7, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2020

📌 Commit 77d4f94 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2020
@bors
Copy link
Contributor

bors commented Sep 7, 2020

⌛ Testing commit 77d4f94 with merge faa5291f1e7b25ba498873e1ff37c0688edcd4db...

@bors
Copy link
Contributor

bors commented Sep 7, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 8, 2020

#76442

\rustdoc-ui\failed-doctest-output.rs
diff of stdout:

1	
2	running 2 tests
-	test $DIR/failed-doctest-output.rs - OtherStruct (line 21) ... FAILED
4	test $DIR/failed-doctest-output.rs - SomeStruct (line 11) ... FAILED
+	test $DIR/failed-doctest-output.rs - OtherStruct (line 21) ... FAILED

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2020
@bors
Copy link
Contributor

bors commented Sep 8, 2020

⌛ Testing commit 77d4f94 with merge fa79db8...

@bors
Copy link
Contributor

bors commented Sep 8, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing fa79db8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 8, 2020
@bors bors merged commit fa79db8 into rust-lang:master Sep 8, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants