Set incremental = true in config.toml.example
#76417
Conversation
This does not affect any x.py defaults, or any contributors that have an existing config.toml. It only affects the settings for new contributors. This has been recommended by rustc-dev-guide for many months. I'm not aware of people running into much trouble with it and it saves an *enormous* amount of time when recompiling. It also requires recompiling all of `rustc` when changed.
rust-highfive
added
the
S-waiting-on-review
jyn514
added
the
T-bootstrap
|
I don't think we should have the example configuration provide just this value as a non-default. If we truly believe that it is a good default (I would like to see a comparison of edit-rerun cycle times for a change to something like rustc_middle), then it seems like we should set it by default for everyone. One thing I would be fine with is adding a config.toml.developers or so, that explicitly sets a subset of options we believe to be good for local development (vs distros or CI). It could even also be all commented out and simply declare developer=true at the top level, which would change defaults in bootstrap to whatever the latest "best" configuration is. |
|
Hmm ... I guess I was imagining That said the rest of your points make sense. Do you think this would be useful for CI/distros? I'm worried I'll get more angry emails from @infinity0 :P |
|
I agree with what Mark said, but also that I would also encourage to keep in mind that there are people who want to build from source for whatever reason. It's not just contributors or CI or distros. |
|
Among the issues mentioned above it often causes 32-bit builds on Windows to fail because rustc needs more memory with incemental objects. |
|
|
||
| # Build a multi-threaded rustc | ||
| # FIXME(#75760): Some UI tests fail when this option is enabled. |
There was a problem hiding this comment.
I believe this could be added separately.
|
I don't think we should set it to true by default but we could add a note that is is recommended to turn it on. Since there are some drawbacks, maybe we could mention why it wasn't on by default there too. |
|
Ok, I'll close this in favor of the rustc-dev-guide instructions then. |
|
@jyn514 In my humble opinion, I think it is good to mention it in the comment that it is recommended like you did. |
This does not affect any x.py defaults, or any contributors that have an
existing config.toml. It only affects the settings for new contributors.
This has been recommended by rustc-dev-guide for many months.
I'm not aware of people running into much trouble with it and it saves
an enormous amount of time when recompiling. It also requires
recompiling all of
rustcwhen changed.r? @Mark-Simulacrum