Add host triples to CI builders #76639
Conversation
Mark-Simulacrum
force-pushed
the
ci-hosts
branch
from
8e82d01 to
fb47bda
Compare
|
I will work through the rest of the CI logs, but that'll take some time. We have until tonight's nightly to land this PR (if we want it fixed ASAP). |
|
I've checked the two CI upload buckets and I think after this PR the artifacts we publish should be good. I'm still downloading CI logs to check tests etc. |
jyn514
added
T-bootstrap
It is really painful to inspect differences in what was built in CI if things are appearing and disappearing randomly as they hover around the 100ms mark. No matter what we choose there's always going to be quite a bit of variability on CI in timing, so we're going to see things appear and vanish.
|
Okay, it turns out we don't print all timings, just those above 100ms which makes comparing logs quite painful, but I think I can explain most of the differences by that 100ms barrier. I also added a commit here which disables that 100ms marker so that we can, in the future, more readily compare CI logs without running into this problem. |
|
@bors r+ p=100 |
|
📌 Commit e788b1a has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
…oalbini Add host triples to target lists This PR is primarily intended to fix rust-lang/rustup#2494, which is the second commit. That bug was introduced by rust-lang#76415, and incompletely fixed by rust-lang#76639. (rust-lang#76639 added host triples, which gave us compilers, but missed that we also need documentation and other target-only things). However, it also removes duplicate macOS CI builders. r? `@pietroalbini`
This is a follow-up to #76415, which changed how x.py interprets cross-compilation target/host flags. This should fix the known cases, but I'm still working through CI logs before/after that PR to identify if anything else is missing.