-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give impl Trait
in a const fn
its own feature gate
#77464
Conversation
0f57b23
to
9a84b5a
Compare
impl Trait
in a const-context its own feature gateimpl Trait
in a const fn
its own feature gate
2b357d6
to
b8a8921
Compare
☔ The latest upstream changes (presumably #76448) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
Yea I think this should just apply to all const contexts |
cf34958
to
7e9e4ce
Compare
7e9e4ce
to
5cdd144
Compare
r=me with ci passing (error index needs updating) |
5cdd144
to
b5693a3
Compare
@bors r=oli-obk rollup |
📌 Commit b5693a3 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☀️ Test successful - checks-actions, checks-azure |
...previously it was gated under
#![feature(const_fn)]
.I think we actually want to do this in all const-contexts? If so, this should be
#![feature(const_impl_trait)]
instead. I don't think there's any way to make use ofimpl Trait
within aconst
initializer.cc #77463
r? @oli-obk