Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to report on closures to avoid ICE #78268

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Do not try to report on closures to avoid ICE #78268

merged 2 commits into from
Oct 26, 2020

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Oct 23, 2020 •
edited
Loading

Fixes #78262

@JohnTitor
Copy link
Member Author

The check was removed in #73783 and I think it's the cause of ICE so r? @estebank

@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 23, 2020
@JohnTitor
Copy link
Member Author

Beta-nominating as ICE fix and it's the latest regression-from-stable-to-stable.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2020

📌 Commit 50e34d6 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 23, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Oct 23, 2020
Closed
@jonas-schievink
Copy link
Contributor

@bors r- failed in #78311 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 23, 2020
@JohnTitor
Copy link
Member Author

Addressed the failure via 4ec396e.
@bors r=estebank

@bors
Copy link
Contributor

bors commented Oct 25, 2020

📌 Commit 4ec396e has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 25, 2020
@Dylan-DPC
Rollup merge of rust-lang#78268 - JohnTitor:issue-78262, r=estebank
73c9339 
Do not try to report on closures to avoid ICE

Fixes rust-lang#78262
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 25, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 25, 2020
@Dylan-DPC
Rollup merge of rust-lang#78268 - JohnTitor:issue-78262, r=estebank
93b4abf 
Do not try to report on closures to avoid ICE

Fixes rust-lang#78262
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 25, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 26, 2020
@Dylan-DPC
Rollup merge of rust-lang#78268 - JohnTitor:issue-78262, r=estebank
2e741a8 
Do not try to report on closures to avoid ICE

Fixes rust-lang#78262
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 26, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 26, 2020
@Dylan-DPC
Rollup merge of rust-lang#78268 - JohnTitor:issue-78262, r=estebank
e86664e 
Do not try to report on closures to avoid ICE

Fixes rust-lang#78262
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 26, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 26, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2020
@bors
Auto merge of rust-lang#78387 - Dylan-DPC:rollup-ch0st6z, r=Dylan-DPC
1cd97ca 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#74477 (`#[deny(unsafe_op_in_unsafe_fn)]` in sys/wasm)
 - rust-lang#77836 (transmute_copy: explain that alignment is handled correctly)
 - rust-lang#78126 (Properly define va_arg and va_list for aarch64-apple-darwin)
 - rust-lang#78137 (Initialize tracing subscriber in compiletest tool)
 - rust-lang#78161 (Add issue template link to IRLO)
 - rust-lang#78214 (Tweak match arm semicolon removal suggestion to account for futures)
 - rust-lang#78247 (Fix rust-lang#78192)
 - rust-lang#78252 (Add codegen test for rust-lang#45964)
 - rust-lang#78268 (Do not try to report on closures to avoid ICE)
 - rust-lang#78295 (Add some regression tests)

Failed merges:

r? `@ghost`
@bors bors merged commit 463b6cc into rust-lang:master Oct 26, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 26, 2020
@JohnTitor JohnTitor deleted the issue-78262 branch October 26, 2020 07:06
@spastorino
Copy link
Member

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 29, 2020
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.49.0, 1.48.0 Nov 5, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 5, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Nov 5, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2020
@bors
Auto merge of rust-lang#78783 - Mark-Simulacrum:beta-next, r=Mark-Sim…
4f9dc0a 
…ulacrum

[beta] backports

This backports a number of PRs to beta:

* Add delay_span_bug to no longer ICE rust-lang#78645
* Do not ICE on invalid input rust-lang#78422
* revert rust-lang#75443, update mir validator rust-lang#78410
* Do not try to report on closures to avoid ICE rust-lang#78268
* Disable "optimization to avoid load of address" in InstCombine rust-lang#78195
* Disable MatchBranchSimplification rust-lang#78151
* Do not ICE with TraitPredicates containing [type error] rust-lang#77930
* Tweak `if let` suggestion to be more liberal with suggestion and to not ICE rust-lang#77283
* Use different mirror for linux headers in musl-toolchain CI script. rust-lang#78316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

Panic at computing function signature of closure with trait object
7 participants
@JohnTitor @estebank @bors @jonas-schievink @spastorino @Mark-Simulacrum @rustbot