Fix persisted doctests on Windows / when using workspaces #79413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the unstable `--persist-doctests` option, Windows path separators were not escaped properly. Also when running the command in a workspace, crate files can overwrite each other. Before: `src\lib_rs_1_0\rust_out` After: `\crate_a_src_lib_rs_1_0\rust_out`, `\crate_b_src_lib_rs_1_0\rust_out`
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Nov 25, 2020
|
Since there is a little change in the naming, I'll ask for others to confirm they're fine with it. cc @jyn514 |
jyn514
added
A-doctests
|
I'm a little confused - where is the name used currently? Is this just for build artifacts, or could some crate be depending on the name? |
Yes, basically its the directory name where the executables end up if you use |
|
Seems fine to me then. @bors r=GuillaumeGomez |
|
📌 Commit 1d587d8 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1d587d8 with merge 3e0ee17c0c67393a9ef1dde4c249f3a2be86c1f0... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
This was referenced Nov 26, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 26, 2020
…as-schievink Rollup of 10 pull requests Successful merges: - rust-lang#77758 (suggest turbofish syntax for uninferred const arguments) - rust-lang#79000 (Move lev_distance to rustc_ast, make non-generic) - rust-lang#79362 (Lower patterns before using the bound variable) - rust-lang#79365 (Upgrades the coverage map to Version 4) - rust-lang#79402 (Fix typos) - rust-lang#79412 (Clean up rustdoc tests by removing unnecessary features) - rust-lang#79413 (Fix persisted doctests on Windows / when using workspaces) - rust-lang#79420 (Fixes a word typo in librustdoc) - rust-lang#79421 (Fix docs formatting for `thir::pattern::_match`) - rust-lang#79428 (Fixup compiler docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the unstable
--persist-doctestsoption,Windows path separators were not escaped properly. Also when running
the command in a workspace, crate files can overwrite each other.
Before:
src\lib_rs_1_0\rust_outAfter:
\crate_a_src_lib_rs_1_0\rust_out,\crate_b_src_lib_rs_1_0\rust_out